mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 11:52:40 +01:00
79218b6e47
Summary: Links from lint errors for large diffs don't work. This diff adds TODO for it because I am not sure how to do it. Move of changeset links rendering to a separate method would be still useful. Test Plan: Display ToC of large diff, verify link. Repeat for small diff. Reviewers: tuomaspelkonen, epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1476
96 lines
3.1 KiB
PHP
96 lines
3.1 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class DifferentialLintFieldSpecification
|
|
extends DifferentialFieldSpecification {
|
|
|
|
public function shouldAppearOnRevisionView() {
|
|
return true;
|
|
}
|
|
|
|
public function renderLabelForRevisionView() {
|
|
return 'Lint:';
|
|
}
|
|
|
|
public function getRequiredDiffProperties() {
|
|
return array('arc:lint');
|
|
}
|
|
|
|
public function renderValueForRevisionView() {
|
|
$diff = $this->getDiff();
|
|
$path_changesets = mpull($diff->loadChangesets(), 'getId', 'getFilename');
|
|
|
|
$lstar = DifferentialRevisionUpdateHistoryView::renderDiffLintStar($diff);
|
|
$lmsg = DifferentialRevisionUpdateHistoryView::getDiffLintMessage($diff);
|
|
$ldata = $this->getDiffProperty('arc:lint');
|
|
$ltail = null;
|
|
if ($ldata) {
|
|
$ldata = igroup($ldata, 'path');
|
|
$lint_messages = array();
|
|
foreach ($ldata as $path => $messages) {
|
|
$message_markup = array();
|
|
foreach ($messages as $message) {
|
|
$path = idx($message, 'path');
|
|
$line = idx($message, 'line');
|
|
|
|
$code = idx($message, 'code');
|
|
$severity = idx($message, 'severity');
|
|
|
|
$name = idx($message, 'name');
|
|
$description = idx($message, 'description');
|
|
|
|
$line_link = phutil_escape_html($line);
|
|
if (isset($path_changesets[$path])) {
|
|
// TODO: Create standalone links for large diffs. Logic is in
|
|
// DifferentialDiffTableOfContentsView::renderChangesetLink().
|
|
$line_link = phutil_render_tag(
|
|
'a',
|
|
array(
|
|
'href' => '#C'.$path_changesets[$path].'NL'.$line,
|
|
),
|
|
$line_link);
|
|
}
|
|
$message_markup[] =
|
|
'<li>'.
|
|
'<span class="lint-severity-'.phutil_escape_html($severity).'">'.
|
|
phutil_escape_html(ucwords($severity)).
|
|
'</span>'.
|
|
' '.
|
|
'('.phutil_escape_html($code).') '.
|
|
phutil_escape_html($name).
|
|
' at line '.$line_link.
|
|
'<p>'.phutil_escape_html($description).'</p>'.
|
|
'</li>';
|
|
}
|
|
$lint_messages[] =
|
|
'<li class="lint-file-block">'.
|
|
'Lint for <strong>'.phutil_escape_html($path).'</strong>'.
|
|
'<ul>'.implode("\n", $message_markup).'</ul>'.
|
|
'</li>';
|
|
}
|
|
$ltail =
|
|
'<div class="differential-lint-block">'.
|
|
'<ul>'.
|
|
implode("\n", $lint_messages).
|
|
'</ul>'.
|
|
'</div>';
|
|
}
|
|
|
|
return $lstar.' '.$lmsg.$ltail;
|
|
}
|
|
}
|