1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 18:32:41 +01:00
phorge-phorge/src/applications/config/controller
epriestley 7a39ac43b4 Add a "list<regex>" config option and move regex config to it
Summary:
Fixes T3807. Several issues:

  - Currently, we split config of type `list<string>` on commas, which makes it impossible to enter a regex with a comma in it.
    - Split on newlines only.
  - Some of the examples are confusing (provided in JSON instead of the format you actually have to enter them).
    - Show examples in the same format you should enter text.
  - We didn't validate regexps.
    - Introduce `list<regex>` to validate regexes.

@hlau: Note that the old config format for the bugtraq stuff implied the delimiters on the regular expression. They are no longer implied. The examples show the correct format.

Test Plan: Viewed and edited affected config, hitting error and success cases.

Reviewers: btrahan

Reviewed By: btrahan

CC: hlau, aran

Maniphest Tasks: T3807

Differential Revision: https://secure.phabricator.com/D6969
2013-09-13 11:48:00 -07:00
..
PhabricatorConfigAllController.php Remove dust from page construction 2013-08-19 18:09:35 -07:00
PhabricatorConfigController.php Two minor Config sidebar tweaks. 2013-01-21 18:55:54 -08:00
PhabricatorConfigEditController.php Add a "list<regex>" config option and move regex config to it 2013-09-13 11:48:00 -07:00
PhabricatorConfigGroupController.php Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00
PhabricatorConfigIgnoreController.php Improve "Ignore" action for setup warnings 2013-07-12 11:20:24 -07:00
PhabricatorConfigIssueListController.php Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00
PhabricatorConfigIssueViewController.php Config option to ignore setup issues 2013-02-22 10:08:20 -08:00
PhabricatorConfigListController.php Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00