1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-04 04:32:43 +01:00
phorge-phorge/src/applications/owners/xaction
epriestley 8fab8d8a18 Prepare owners package audit rules to become more flexible
Summary:
Ref T13244. See PHI1055. (Earlier, see D20091 and PHI1047.) Previously, we expanded the Owners package autoreview rules from "Yes/No" to several "Review (Blocking) If Non-Owner Author Not Subscribed via Package" kinds of rules. The sky didn't fall and this feature didn't turn into "Herald-in-Owners", so I'm comfortable doing something similar to the "Audit" rules.

PHI1055 is a request for a way to configure slightly different audit behavior, and expanding the options seems like a good approach to satisfy the use case.

Prepare to add more options by moving everything into a class that defines all the behavior of different states, and converting the "0/1" boolean column to a text column.

Test Plan:
  - Created several packages, some with and some without auditing.
  - Inspected database for: package state; and associated transactions.
  - Ran the migrations.
  - Inspected database to confirm that state and transactions migrated correctly.
  - Reviewed transaction logs.
  - Created and edited packages and audit state.
  - Viewed the "Package List" element in Diffusion.
  - Pulled package information with `owners.search`, got sensible results.
  - Edited package audit status with `owners.edit`.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13244

Differential Revision: https://secure.phabricator.com/D20124
2019-02-07 15:38:12 -08:00
..
PhabricatorOwnersPackageAuditingTransaction.php Prepare owners package audit rules to become more flexible 2019-02-07 15:38:12 -08:00
PhabricatorOwnersPackageAutoreviewTransaction.php Modularize Owners package transactions 2016-10-13 21:07:02 +00:00
PhabricatorOwnersPackageDescriptionTransaction.php Allow transactions to specialize their mail headers for diff sections 2016-11-07 12:16:39 -08:00
PhabricatorOwnersPackageDominionTransaction.php Modularize Owners package transactions 2016-10-13 21:07:02 +00:00
PhabricatorOwnersPackageIgnoredTransaction.php Allow Owners packages to be configured to ignore generated paths in Differential 2018-05-05 08:47:29 -07:00
PhabricatorOwnersPackageNameTransaction.php Modularize Owners package transactions 2016-10-13 21:07:02 +00:00
PhabricatorOwnersPackageOwnersTransaction.php Modularize Owners package transactions 2016-10-13 21:07:02 +00:00
PhabricatorOwnersPackagePathsTransaction.php Fix an issue where entering the same Owners path for two repositories would incorrectly de-dupe the path 2018-05-01 09:57:37 -07:00
PhabricatorOwnersPackagePrimaryTransaction.php Modularize Owners package transactions 2016-10-13 21:07:02 +00:00
PhabricatorOwnersPackageStatusTransaction.php Modularize Owners package transactions 2016-10-13 21:07:02 +00:00
PhabricatorOwnersPackageTransactionType.php Modularize Owners package transactions 2016-10-13 21:07:02 +00:00