mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-23 10:48:47 +02:00
dd501117e8
Summary: Ref T2009. Ref T1460. Fixes T2618. When users hit "Delete" on inline comments, delete immediately and offer them "Undo". If they delete indirectly (e.g., by clicking "Delete" from the preview at the bottom of the page), we still prompt them, because the "Undo" action either won't be available or may not be easy to find. This is a "refdelete". Fixes T6464. This was just a mess. Make it not as much of a mess. It should work now. Pretty sure. Fixes T4999. We did not refresh these links often enough to find targets for them, so they could race with content. Reevaluate them after loading new changes. Test Plan: - Deleted and undid deletion of inlines from main view and preview. - Clicked "View" on inlines. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T6464, T4999, T2618, T1460, T2009 Differential Revision: https://secure.phabricator.com/D12032
99 lines
2.5 KiB
JavaScript
99 lines
2.5 KiB
JavaScript
/**
|
|
* @provides javelin-behavior-differential-feedback-preview
|
|
* @requires javelin-behavior
|
|
* javelin-stratcom
|
|
* javelin-dom
|
|
* javelin-request
|
|
* javelin-util
|
|
* phabricator-shaped-request
|
|
*/
|
|
|
|
JX.behavior('differential-feedback-preview', function(config) {
|
|
|
|
var action = JX.$(config.action);
|
|
var content = JX.$(config.content);
|
|
var previewTokenizers = {};
|
|
var field;
|
|
for (field in config.previewTokenizers) {
|
|
var tokenizer = JX.$(config.previewTokenizers[field]);
|
|
previewTokenizers[field] = JX.Stratcom.getData(tokenizer).tokenizer;
|
|
}
|
|
|
|
var callback = function(r) {
|
|
var preview = JX.$(config.preview);
|
|
JX.DOM.setContent(preview, JX.$H(r));
|
|
JX.Stratcom.invoke('differential-preview-update', null, {
|
|
container: preview
|
|
});
|
|
};
|
|
|
|
var getdata = function() {
|
|
var data = {
|
|
content : content.value,
|
|
action : action.value
|
|
};
|
|
for (var field in previewTokenizers) {
|
|
data[field] = JX.keys(previewTokenizers[field].getTokens()).join(',');
|
|
}
|
|
return data;
|
|
};
|
|
|
|
var request = new JX.PhabricatorShapedRequest(config.uri, callback, getdata);
|
|
var trigger = JX.bind(request, request.trigger);
|
|
|
|
JX.DOM.listen(content, 'keydown', null, trigger);
|
|
JX.DOM.listen(action, 'change', null, trigger);
|
|
for (field in previewTokenizers) {
|
|
previewTokenizers[field].listen('change', trigger);
|
|
}
|
|
|
|
request.start();
|
|
|
|
function refreshInlinePreview() {
|
|
new JX.Request(config.inlineuri, function(r) {
|
|
var inline = JX.$(config.inline);
|
|
|
|
JX.DOM.setContent(inline, JX.$H(r));
|
|
JX.Stratcom.invoke('differential-preview-update', null, {
|
|
container: inline
|
|
});
|
|
|
|
updateLinks();
|
|
})
|
|
.setTimeout(5000)
|
|
.send();
|
|
}
|
|
|
|
function updateLinks() {
|
|
var inline = JX.$(config.inline);
|
|
|
|
var links = JX.DOM.scry(
|
|
inline,
|
|
'a',
|
|
'differential-inline-preview-jump');
|
|
|
|
for (var ii = 0; ii < links.length; ii++) {
|
|
var data = JX.Stratcom.getData(links[ii]);
|
|
try {
|
|
JX.$(data.anchor);
|
|
links[ii].href = '#' + data.anchor;
|
|
JX.DOM.setContent(links[ii], 'View');
|
|
} catch (ignored) {
|
|
// This inline comment isn't visible, e.g. on some other diff.
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
JX.Stratcom.listen(
|
|
'differential-inline-comment-update',
|
|
null,
|
|
refreshInlinePreview);
|
|
|
|
JX.Stratcom.listen(
|
|
'differential-inline-comment-refresh',
|
|
null,
|
|
updateLinks);
|
|
|
|
refreshInlinePreview();
|
|
});
|