mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-21 09:48:47 +02:00
c35cafda2c
Summary: Fixes T4452. Ref T2009. There's a hierarchy of changeset rendering power: only low-level calls, use of ChangesetDetailView, then use of ChangesetListView (a list of DetailViews). Prior to work here, the various changeset rendering controllers got their hands dirty to varying degrees, with some using only the lowest-level rendering pipeline: - Phriction: no view (lowest level) - Diffusion: DetailView - Differential Changeset: DetailView - Differential Diff: ListView - Differential Revision: ListView I brought Phriction up to use DetailView, but want to bring everything all the way up to use ListView. Each composition layer adds more features to diff browsing. In particular, this change enables "Highlight As", switching 1up vs 2up, adding inlines, etc., on the standalone view. Test Plan: - Viewed a changeset standalone. Could change highlighting, switch 1up vs 2up, add and edit inlines, etc. - Viewed a revision; no behavioral changes. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4452, T2009 Differential Revision: https://secure.phabricator.com/D12012 |
||
|---|---|---|
| .. | ||
| behavior-add-reviewers-and-ccs.js | ||
| behavior-comment-jump.js | ||
| behavior-comment-preview.js | ||
| behavior-diff-radios.js | ||
| behavior-dropdown-menus.js | ||
| behavior-edit-inline-comments.js | ||
| behavior-keyboard-nav.js | ||
| behavior-populate.js | ||
| behavior-show-field-details.js | ||
| behavior-toggle-files.js | ||
| behavior-user-select.js | ||
| ChangesetViewManager.js | ||
| DifferentialInlineCommentEditor.js | ||