1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/audit
epriestley 11c5638832 Fix some error log issues with uninitialized commit/revision lists
Summary:
Fixes T12679. Reproduction steps appear to be:

  - As a logged-out user, view revision list or commit list.
  - Enable bucketing by action required.
  - Before patch: `foreach (null as ...)` causes error spew.
  - After patch: `foreach (array() as ...)` works great.

Test Plan:
  - Reproduced issue by following steps above in Differential (revisions) and Diffusion (audits/commits).
  - After patches, no more errors in the log.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T12679

Differential Revision: https://secure.phabricator.com/D17872
2017-05-14 13:28:02 -07:00
..
application Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
conduit Remove several pieces of audit-related code 2017-01-30 15:26:26 -08:00
constants Remove several pieces of audit-related code 2017-01-30 15:26:26 -08:00
controller Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
editor Ignore "Auditors: author" when inferring auditors from commit messages 2017-03-16 13:57:51 -07:00
mail Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
management Make "bin/audit synchronize" actually save changes 2017-01-31 12:23:49 -08:00
query Restrict Audit buckets to just ApplicationSearch views 2017-03-23 12:46:19 -07:00
storage Give Audit an informational "This commit now requires (something)..." transaction 2017-01-25 07:53:18 -08:00
view Fix some error log issues with uninitialized commit/revision lists 2017-05-14 13:28:02 -07:00