mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-28 17:52:43 +01:00
3a002b6b83
Summary: Fixes T11437. Provides a normal form for configuring this, instead of weird "look up the PHID and adjust things in the database" stuff. Test Plan: {F1753651} {F1753652} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11437 Differential Revision: https://secure.phabricator.com/D16377
595 lines
16 KiB
PHP
595 lines
16 KiB
PHP
<?php
|
|
|
|
final class PhabricatorConfigEditController
|
|
extends PhabricatorConfigController {
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $request->getViewer();
|
|
$key = $request->getURIData('key');
|
|
|
|
|
|
$options = PhabricatorApplicationConfigOptions::loadAllOptions();
|
|
if (empty($options[$key])) {
|
|
$ancient = PhabricatorExtraConfigSetupCheck::getAncientConfig();
|
|
if (isset($ancient[$key])) {
|
|
$desc = pht(
|
|
"This configuration has been removed. You can safely delete ".
|
|
"it.\n\n%s",
|
|
$ancient[$key]);
|
|
} else {
|
|
$desc = pht(
|
|
'This configuration option is unknown. It may be misspelled, '.
|
|
'or have existed in a previous version of Phabricator.');
|
|
}
|
|
|
|
// This may be a dead config entry, which existed in the past but no
|
|
// longer exists. Allow it to be edited so it can be reviewed and
|
|
// deleted.
|
|
$option = id(new PhabricatorConfigOption())
|
|
->setKey($key)
|
|
->setType('wild')
|
|
->setDefault(null)
|
|
->setDescription($desc);
|
|
$group = null;
|
|
$group_uri = $this->getApplicationURI();
|
|
} else {
|
|
$option = $options[$key];
|
|
$group = $option->getGroup();
|
|
$group_uri = $this->getApplicationURI('group/'.$group->getKey().'/');
|
|
}
|
|
|
|
$issue = $request->getStr('issue');
|
|
if ($issue) {
|
|
// If the user came here from an open setup issue, send them back.
|
|
$done_uri = $this->getApplicationURI('issue/'.$issue.'/');
|
|
} else {
|
|
$done_uri = $group_uri;
|
|
}
|
|
|
|
// Check if the config key is already stored in the database.
|
|
// Grab the value if it is.
|
|
$config_entry = id(new PhabricatorConfigEntry())
|
|
->loadOneWhere(
|
|
'configKey = %s AND namespace = %s',
|
|
$key,
|
|
'default');
|
|
if (!$config_entry) {
|
|
$config_entry = id(new PhabricatorConfigEntry())
|
|
->setConfigKey($key)
|
|
->setNamespace('default')
|
|
->setIsDeleted(true);
|
|
$config_entry->setPHID($config_entry->generatePHID());
|
|
}
|
|
|
|
$e_value = null;
|
|
$errors = array();
|
|
if ($request->isFormPost() && !$option->getLocked()) {
|
|
|
|
$result = $this->readRequest(
|
|
$option,
|
|
$request);
|
|
|
|
list($e_value, $value_errors, $display_value, $xaction) = $result;
|
|
$errors = array_merge($errors, $value_errors);
|
|
|
|
if (!$errors) {
|
|
|
|
$editor = id(new PhabricatorConfigEditor())
|
|
->setActor($viewer)
|
|
->setContinueOnNoEffect(true)
|
|
->setContentSourceFromRequest($request);
|
|
|
|
try {
|
|
$editor->applyTransactions($config_entry, array($xaction));
|
|
return id(new AphrontRedirectResponse())->setURI($done_uri);
|
|
} catch (PhabricatorConfigValidationException $ex) {
|
|
$e_value = pht('Invalid');
|
|
$errors[] = $ex->getMessage();
|
|
}
|
|
}
|
|
} else {
|
|
if ($config_entry->getIsDeleted()) {
|
|
$display_value = null;
|
|
} else {
|
|
$display_value = $this->getDisplayValue(
|
|
$option,
|
|
$config_entry,
|
|
$config_entry->getValue());
|
|
}
|
|
}
|
|
|
|
$form = id(new AphrontFormView())
|
|
->setEncType('multipart/form-data');
|
|
|
|
$error_view = null;
|
|
if ($errors) {
|
|
$error_view = id(new PHUIInfoView())
|
|
->setErrors($errors);
|
|
}
|
|
|
|
$status_items = array();
|
|
if ($option->getHidden()) {
|
|
$message = pht(
|
|
'This configuration is hidden and can not be edited or viewed from '.
|
|
'the web interface.');
|
|
|
|
$status_items[] = id(new PHUIStatusItemView())
|
|
->setIcon('fa-eye-slash red')
|
|
->setTarget(phutil_tag('strong', array(), pht('Configuration Hidden')))
|
|
->setNote($message);
|
|
} else if ($option->getLocked()) {
|
|
$message = $option->getLockedMessage();
|
|
|
|
$status_items[] = id(new PHUIStatusItemView())
|
|
->setIcon('fa-lock red')
|
|
->setTarget(phutil_tag('strong', array(), pht('Configuration Locked')))
|
|
->setNote($message);
|
|
}
|
|
|
|
if ($status_items) {
|
|
$doc_href = PhabricatorEnv::getDoclink(
|
|
'Configuration Guide: Locked and Hidden Configuration');
|
|
|
|
$doc_link = phutil_tag(
|
|
'a',
|
|
array(
|
|
'href' => $doc_href,
|
|
'target' => '_blank',
|
|
),
|
|
pht('Configuration Guide: Locked and Hidden Configuration'));
|
|
|
|
$status_items[] = id(new PHUIStatusItemView())
|
|
->setIcon('fa-book')
|
|
->setTarget(phutil_tag('strong', array(), pht('Learn More')))
|
|
->setNote($doc_link);
|
|
}
|
|
|
|
if ($option->getHidden() || $option->getLocked()) {
|
|
$controls = array();
|
|
} else {
|
|
$controls = $this->renderControls(
|
|
$option,
|
|
$display_value,
|
|
$e_value);
|
|
}
|
|
|
|
$engine = new PhabricatorMarkupEngine();
|
|
$engine->setViewer($viewer);
|
|
$engine->addObject($option, 'description');
|
|
$engine->process();
|
|
$description = phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'phabricator-remarkup',
|
|
),
|
|
$engine->getOutput($option, 'description'));
|
|
|
|
$form
|
|
->setUser($viewer)
|
|
->addHiddenInput('issue', $request->getStr('issue'));
|
|
|
|
if ($status_items) {
|
|
$status_view = id(new PHUIStatusListView());
|
|
|
|
foreach ($status_items as $status_item) {
|
|
$status_view->addItem($status_item);
|
|
}
|
|
|
|
$form->appendControl(
|
|
id(new AphrontFormMarkupControl())
|
|
->setValue($status_view));
|
|
}
|
|
|
|
$description = $option->getDescription();
|
|
if (strlen($description)) {
|
|
$description_view = new PHUIRemarkupView($viewer, $description);
|
|
|
|
$form
|
|
->appendChild(
|
|
id(new AphrontFormMarkupControl())
|
|
->setLabel(pht('Description'))
|
|
->setValue($description_view));
|
|
}
|
|
|
|
if ($group) {
|
|
$extra = $group->renderContextualDescription(
|
|
$option,
|
|
$request);
|
|
if ($extra !== null) {
|
|
$form->appendChild(
|
|
id(new AphrontFormMarkupControl())
|
|
->setValue($extra));
|
|
}
|
|
}
|
|
|
|
foreach ($controls as $control) {
|
|
$form->appendControl($control);
|
|
}
|
|
|
|
if (!$option->getLocked()) {
|
|
$form->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->addCancelButton($done_uri)
|
|
->setValue(pht('Save Config Entry')));
|
|
}
|
|
|
|
if (!$option->getHidden()) {
|
|
$form->appendChild(
|
|
id(new AphrontFormMarkupControl())
|
|
->setLabel(pht('Current Configuration'))
|
|
->setValue($this->renderDefaults($option, $config_entry)));
|
|
}
|
|
|
|
$examples = $this->renderExamples($option);
|
|
if ($examples) {
|
|
$form->appendChild(
|
|
id(new AphrontFormMarkupControl())
|
|
->setLabel(pht('Examples'))
|
|
->setValue($examples));
|
|
}
|
|
|
|
$title = pht('Edit Option: %s', $key);
|
|
$header_icon = 'fa-pencil';
|
|
$short = pht('Edit');
|
|
|
|
$form_box = id(new PHUIObjectBoxView())
|
|
->setHeaderText(pht('Config Option'))
|
|
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
|
->setForm($form);
|
|
|
|
if ($error_view) {
|
|
$form_box->setInfoView($error_view);
|
|
}
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addTextCrumb(pht('Config'), $this->getApplicationURI());
|
|
|
|
if ($group) {
|
|
$crumbs->addTextCrumb($group->getName(), $group_uri);
|
|
}
|
|
|
|
$crumbs->addTextCrumb($key, '/config/edit/'.$key);
|
|
$crumbs->setBorder(true);
|
|
|
|
$timeline = $this->buildTransactionTimeline(
|
|
$config_entry,
|
|
new PhabricatorConfigTransactionQuery());
|
|
$timeline->setShouldTerminate(true);
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
->setHeader($title)
|
|
->setHeaderIcon($header_icon);
|
|
|
|
$view = id(new PHUITwoColumnView())
|
|
->setHeader($header)
|
|
->setFooter($form_box);
|
|
|
|
return $this->newPage()
|
|
->setTitle($title)
|
|
->setCrumbs($crumbs)
|
|
->appendChild($view);
|
|
}
|
|
|
|
private function readRequest(
|
|
PhabricatorConfigOption $option,
|
|
AphrontRequest $request) {
|
|
|
|
$xaction = new PhabricatorConfigTransaction();
|
|
$xaction->setTransactionType(PhabricatorConfigTransaction::TYPE_EDIT);
|
|
|
|
$e_value = null;
|
|
$errors = array();
|
|
|
|
if ($option->isCustomType()) {
|
|
$info = $option->getCustomObject()->readRequest($option, $request);
|
|
list($e_value, $errors, $set_value, $value) = $info;
|
|
} else {
|
|
$value = $request->getStr('value');
|
|
if (!strlen($value)) {
|
|
$value = null;
|
|
|
|
$xaction->setNewValue(
|
|
array(
|
|
'deleted' => true,
|
|
'value' => null,
|
|
));
|
|
|
|
return array($e_value, $errors, $value, $xaction);
|
|
}
|
|
|
|
$type = $option->getType();
|
|
$set_value = null;
|
|
|
|
switch ($type) {
|
|
case 'int':
|
|
if (preg_match('/^-?[0-9]+$/', trim($value))) {
|
|
$set_value = (int)$value;
|
|
} else {
|
|
$e_value = pht('Invalid');
|
|
$errors[] = pht('Value must be an integer.');
|
|
}
|
|
break;
|
|
case 'string':
|
|
case 'enum':
|
|
$set_value = (string)$value;
|
|
break;
|
|
case 'list<string>':
|
|
case 'list<regex>':
|
|
$set_value = phutil_split_lines(
|
|
$request->getStr('value'),
|
|
$retain_endings = false);
|
|
|
|
foreach ($set_value as $key => $v) {
|
|
if (!strlen($v)) {
|
|
unset($set_value[$key]);
|
|
}
|
|
}
|
|
$set_value = array_values($set_value);
|
|
|
|
break;
|
|
case 'set':
|
|
$set_value = array_fill_keys($request->getStrList('value'), true);
|
|
break;
|
|
case 'bool':
|
|
switch ($value) {
|
|
case 'true':
|
|
$set_value = true;
|
|
break;
|
|
case 'false':
|
|
$set_value = false;
|
|
break;
|
|
default:
|
|
$e_value = pht('Invalid');
|
|
$errors[] = pht('Value must be boolean, "true" or "false".');
|
|
break;
|
|
}
|
|
break;
|
|
case 'class':
|
|
if (!class_exists($value)) {
|
|
$e_value = pht('Invalid');
|
|
$errors[] = pht('Class does not exist.');
|
|
} else {
|
|
$base = $option->getBaseClass();
|
|
if (!is_subclass_of($value, $base)) {
|
|
$e_value = pht('Invalid');
|
|
$errors[] = pht('Class is not of valid type.');
|
|
} else {
|
|
$set_value = $value;
|
|
}
|
|
}
|
|
break;
|
|
default:
|
|
$json = json_decode($value, true);
|
|
if ($json === null && strtolower($value) != 'null') {
|
|
$e_value = pht('Invalid');
|
|
$errors[] = pht(
|
|
'The given value must be valid JSON. This means, among '.
|
|
'other things, that you must wrap strings in double-quotes.');
|
|
} else {
|
|
$set_value = $json;
|
|
}
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (!$errors) {
|
|
$xaction->setNewValue(
|
|
array(
|
|
'deleted' => false,
|
|
'value' => $set_value,
|
|
));
|
|
} else {
|
|
$xaction = null;
|
|
}
|
|
|
|
return array($e_value, $errors, $value, $xaction);
|
|
}
|
|
|
|
private function getDisplayValue(
|
|
PhabricatorConfigOption $option,
|
|
PhabricatorConfigEntry $entry,
|
|
$value) {
|
|
|
|
if ($option->isCustomType()) {
|
|
return $option->getCustomObject()->getDisplayValue(
|
|
$option,
|
|
$entry,
|
|
$value);
|
|
} else {
|
|
$type = $option->getType();
|
|
switch ($type) {
|
|
case 'int':
|
|
case 'string':
|
|
case 'enum':
|
|
case 'class':
|
|
return $value;
|
|
case 'bool':
|
|
return $value ? 'true' : 'false';
|
|
case 'list<string>':
|
|
case 'list<regex>':
|
|
return implode("\n", nonempty($value, array()));
|
|
case 'set':
|
|
return implode("\n", nonempty(array_keys($value), array()));
|
|
default:
|
|
return PhabricatorConfigJSON::prettyPrintJSON($value);
|
|
}
|
|
}
|
|
}
|
|
|
|
private function renderControls(
|
|
PhabricatorConfigOption $option,
|
|
$display_value,
|
|
$e_value) {
|
|
|
|
if ($option->isCustomType()) {
|
|
$controls = $option->getCustomObject()->renderControls(
|
|
$option,
|
|
$display_value,
|
|
$e_value);
|
|
} else {
|
|
$type = $option->getType();
|
|
switch ($type) {
|
|
case 'int':
|
|
case 'string':
|
|
$control = id(new AphrontFormTextControl());
|
|
break;
|
|
case 'bool':
|
|
$control = id(new AphrontFormSelectControl())
|
|
->setOptions(
|
|
array(
|
|
'' => pht('(Use Default)'),
|
|
'true' => idx($option->getBoolOptions(), 0),
|
|
'false' => idx($option->getBoolOptions(), 1),
|
|
));
|
|
break;
|
|
case 'enum':
|
|
$options = array_mergev(
|
|
array(
|
|
array('' => pht('(Use Default)')),
|
|
$option->getEnumOptions(),
|
|
));
|
|
$control = id(new AphrontFormSelectControl())
|
|
->setOptions($options);
|
|
break;
|
|
case 'class':
|
|
$symbols = id(new PhutilSymbolLoader())
|
|
->setType('class')
|
|
->setAncestorClass($option->getBaseClass())
|
|
->setConcreteOnly(true)
|
|
->selectSymbolsWithoutLoading();
|
|
$names = ipull($symbols, 'name', 'name');
|
|
asort($names);
|
|
$names = array(
|
|
'' => pht('(Use Default)'),
|
|
) + $names;
|
|
|
|
$control = id(new AphrontFormSelectControl())
|
|
->setOptions($names);
|
|
break;
|
|
case 'list<string>':
|
|
case 'list<regex>':
|
|
$control = id(new AphrontFormTextAreaControl())
|
|
->setCaption(pht('Separate values with newlines.'));
|
|
break;
|
|
case 'set':
|
|
$control = id(new AphrontFormTextAreaControl())
|
|
->setCaption(pht('Separate values with newlines or commas.'));
|
|
break;
|
|
default:
|
|
$control = id(new AphrontFormTextAreaControl())
|
|
->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL)
|
|
->setCustomClass('PhabricatorMonospaced')
|
|
->setCaption(pht('Enter value in JSON.'));
|
|
break;
|
|
}
|
|
|
|
$control
|
|
->setLabel(pht('Database Value'))
|
|
->setError($e_value)
|
|
->setValue($display_value)
|
|
->setName('value');
|
|
|
|
$controls = array($control);
|
|
}
|
|
|
|
return $controls;
|
|
}
|
|
|
|
private function renderExamples(PhabricatorConfigOption $option) {
|
|
$examples = $option->getExamples();
|
|
if (!$examples) {
|
|
return null;
|
|
}
|
|
|
|
$table = array();
|
|
$table[] = phutil_tag('tr', array('class' => 'column-labels'), array(
|
|
phutil_tag('th', array(), pht('Example')),
|
|
phutil_tag('th', array(), pht('Value')),
|
|
));
|
|
foreach ($examples as $example) {
|
|
list($value, $description) = $example;
|
|
|
|
if ($value === null) {
|
|
$value = phutil_tag('em', array(), pht('(empty)'));
|
|
} else {
|
|
if (is_array($value)) {
|
|
$value = implode("\n", $value);
|
|
}
|
|
}
|
|
|
|
$table[] = phutil_tag('tr', array(), array(
|
|
phutil_tag('th', array(), $description),
|
|
phutil_tag('td', array(), $value),
|
|
));
|
|
}
|
|
|
|
require_celerity_resource('config-options-css');
|
|
|
|
return phutil_tag(
|
|
'table',
|
|
array(
|
|
'class' => 'config-option-table',
|
|
),
|
|
$table);
|
|
}
|
|
|
|
private function renderDefaults(
|
|
PhabricatorConfigOption $option,
|
|
PhabricatorConfigEntry $entry) {
|
|
|
|
$stack = PhabricatorEnv::getConfigSourceStack();
|
|
$stack = $stack->getStack();
|
|
|
|
$table = array();
|
|
$table[] = phutil_tag('tr', array('class' => 'column-labels'), array(
|
|
phutil_tag('th', array(), pht('Source')),
|
|
phutil_tag('th', array(), pht('Value')),
|
|
));
|
|
|
|
$is_effective_value = true;
|
|
foreach ($stack as $key => $source) {
|
|
$row_classes = array(
|
|
'column-labels',
|
|
);
|
|
|
|
$value = $source->getKeys(
|
|
array(
|
|
$option->getKey(),
|
|
));
|
|
|
|
if (!array_key_exists($option->getKey(), $value)) {
|
|
$value = phutil_tag('em', array(), pht('(No Value Configured)'));
|
|
} else {
|
|
$value = $this->getDisplayValue(
|
|
$option,
|
|
$entry,
|
|
$value[$option->getKey()]);
|
|
|
|
if ($is_effective_value) {
|
|
$is_effective_value = false;
|
|
$row_classes[] = 'config-options-effective-value';
|
|
}
|
|
}
|
|
|
|
$table[] = phutil_tag(
|
|
'tr',
|
|
array(
|
|
'class' => implode(' ', $row_classes),
|
|
),
|
|
array(
|
|
phutil_tag('th', array(), $source->getName()),
|
|
phutil_tag('td', array(), $value),
|
|
));
|
|
}
|
|
|
|
require_celerity_resource('config-options-css');
|
|
|
|
return phutil_tag(
|
|
'table',
|
|
array(
|
|
'class' => 'config-option-table',
|
|
),
|
|
$table);
|
|
}
|
|
|
|
}
|