1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
phorge-phorge/src
epriestley 7b5e84282f Improve "thread" rendering of unusually-shaped graphs
Summary:
Ref T4788. This fixes all the bugs I was immediately able to catch:

  - "Directory-Like" graph shapes could draw too many vertical lines.
  - "Reverse-Directory-Like" graph shapes could draw too few vertical lines.
  - Terminated, branched graph shapes drew the very last line to the wrong place.

This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything.

Test Plan:
  - Added failing tests and made them pass.

{F1708158}

{F1708159}

{F1708160}

{F1708161}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4788

Differential Revision: https://secure.phabricator.com/D16216
2016-07-01 11:15:24 -07:00
..
__tests__
aphront Continue modernizing application access to user preferences 2016-06-04 14:37:56 -07:00
applications Render parent and child tasks in Maniphest with a graph trace 2016-07-01 10:41:07 -07:00
docs Document the "---" rule in Remarkup 2016-06-28 14:57:46 -07:00
extensions
infrastructure Improve "thread" rendering of unusually-shaped graphs 2016-07-01 11:15:24 -07:00
view Build that thing someone posted a screenshot of on Facebook 2016-07-01 04:36:24 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Improve "thread" rendering of unusually-shaped graphs 2016-07-01 11:15:24 -07:00