1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-23 13:08:18 +01:00
phorge-phorge/src
epriestley 7c4c76d32a Fix a Quicksand/Lightbox contention issue
Summary:
Fixes T11785. Lightbox calls `JX.Stratcom.pass()` to let other handlers react, but should not. At least today, we never put, e.g., links inside a lightbox.

This code appears in the original commit so it was probably just copy/pasted from somewhere and I missed it in review.

(Or there's some edge case I'm not thinking of and we'll figure it out soon enough.)

Additionally, blacklist `/file/data/` from Quicksand naviagtion: Quicksand should never fetch these URIs.

Test Plan:
  - Disabled `security.alternate-file-domain`.
  - Enabled Quicksand ("Persistent Chat").
  - Clicked an image thumbnail on a task.
    - Repeated that until things flipped out a bit.
    - After the patch: no issues.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11785

Differential Revision: https://secure.phabricator.com/D16884
2016-11-16 17:10:56 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Make the "All Day Event" control use a checkbox instead of a dropdown 2016-10-31 14:18:59 -07:00
applications Fix a Quicksand/Lightbox contention issue 2016-11-16 17:10:56 -08:00
docs Document calendar summary icons 2016-11-15 13:44:20 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Document calendar summary icons 2016-11-15 13:44:20 -08:00
view Use the same date rendering display logic for both tooltips and subheaders 2016-11-16 08:37:25 -08:00
__phutil_library_init__.php
__phutil_library_map__.php Add Hero Image to Phame Post 2016-11-15 13:44:47 -08:00