1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-20 19:51:08 +01:00
phorge-phorge/src/applications/macro
epriestley c125ab7a42 Remove "metamta.*.subject-prefix" options
Summary:
In ~2012, the first of these options was added because someone who hates dogs and works at Asana also hated `[Differential]` in the subject line. The use case there was actually //removing// the text, not changing it, but I made the prefix editable since it seemed like slightly less of a one-off.

These options are among the dumbest and most useless config options we have and very rarely used, see T11760. A very small number of instances have configured one of these options.

Newer applications stopped providing these options and no one has complained.

You can get the same effect with `translation.override`. Although I'm not sure we'll keep that around forever, it's a reasonable replacement today. I'll call out an example in the changelog to help installs that want to preserve this option.

If we did want to provide this, it should just be in {nav Applications > Settings} for each application, but I think it's wildly-low-value and "hack via translations" or "local patch" are entirely reasonable if you really want to change these strings.

Test Plan: Grepped for `subject-prefix`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19993
2019-01-17 19:18:50 -08:00
..
application Update Macro comment form 2017-05-03 12:34:21 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit PhabricatorMemeEngine HA HA HA HA 2018-03-08 11:06:52 -08:00
controller PhabricatorMemeEngine HA HA HA HA 2018-03-08 11:06:52 -08:00
editor Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
engine When {meme ...} embed has no text, just use the raw file data unmodified 2018-11-06 09:40:22 -08:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
markup Possibly fix memes in email 2018-03-08 11:09:21 -08:00
phid Provide an application link for the Macro PHID type 2015-10-24 09:41:13 -07:00
query Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
storage Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
typeahead Add some sort of sort to Emoji Autocomplete 2017-01-24 20:21:06 -08:00
xaction Allow a wider range of characters in macro names, including emoji 2018-02-09 14:34:30 -08:00