mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-27 05:59:08 +01:00
f1f8ee8e6a
Summary: Fixes T10357. - Show a better (more descriptive) error message when a user who can't create projects tries to create a subproject or milestone. - Disable the subproject actions if you don't have create permission. All this stuff was already enforced properly: this diff doesn't make any actual policy changes, just improves the UI for users who lack permission. Test Plan: - As an unprivileged user (no "Can Create Projects"), tried to create a subproject or milestone. - After patch, got a disabled action, with more specific and helpful error than before. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10357 Differential Revision: https://secure.phabricator.com/D15274
112 lines
3.1 KiB
PHP
112 lines
3.1 KiB
PHP
<?php
|
|
|
|
final class PhabricatorProjectEditController
|
|
extends PhabricatorProjectController {
|
|
|
|
private $engine;
|
|
|
|
public function setEngine(PhabricatorProjectEditEngine $engine) {
|
|
$this->engine = $engine;
|
|
return $this;
|
|
}
|
|
|
|
public function getEngine() {
|
|
return $this->engine;
|
|
}
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $this->getViewer();
|
|
|
|
$engine = id(new PhabricatorProjectEditEngine())
|
|
->setController($this);
|
|
|
|
$this->setEngine($engine);
|
|
|
|
$id = $request->getURIData('id');
|
|
if (!$id) {
|
|
// This capability is checked again later, but checking it here
|
|
// explicitly gives us a better error message.
|
|
$this->requireApplicationCapability(
|
|
ProjectCreateProjectsCapability::CAPABILITY);
|
|
|
|
$parent_id = head($request->getArr('parent'));
|
|
if (!$parent_id) {
|
|
$parent_id = $request->getStr('parent');
|
|
}
|
|
|
|
if ($parent_id) {
|
|
$is_milestone = false;
|
|
} else {
|
|
$parent_id = head($request->getArr('milestone'));
|
|
if (!$parent_id) {
|
|
$parent_id = $request->getStr('milestone');
|
|
}
|
|
$is_milestone = true;
|
|
}
|
|
|
|
if ($parent_id) {
|
|
$query = id(new PhabricatorProjectQuery())
|
|
->setViewer($viewer)
|
|
->needImages(true)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
));
|
|
|
|
if (ctype_digit($parent_id)) {
|
|
$query->withIDs(array($parent_id));
|
|
} else {
|
|
$query->withPHIDs(array($parent_id));
|
|
}
|
|
|
|
$parent = $query->executeOne();
|
|
|
|
if ($is_milestone) {
|
|
if (!$parent->supportsMilestones()) {
|
|
$cancel_uri = "/project/subprojects/{$parent_id}/";
|
|
return $this->newDialog()
|
|
->setTitle(pht('No Milestones'))
|
|
->appendParagraph(
|
|
pht('You can not add milestones to this project.'))
|
|
->addCancelButton($cancel_uri);
|
|
}
|
|
$engine->setMilestoneProject($parent);
|
|
} else {
|
|
if (!$parent->supportsSubprojects()) {
|
|
$cancel_uri = "/project/subprojects/{$parent_id}/";
|
|
return $this->newDialog()
|
|
->setTitle(pht('No Subprojects'))
|
|
->appendParagraph(
|
|
pht('You can not add subprojects to this project.'))
|
|
->addCancelButton($cancel_uri);
|
|
}
|
|
$engine->setParentProject($parent);
|
|
}
|
|
|
|
$this->setProject($parent);
|
|
}
|
|
}
|
|
|
|
return $engine->buildResponse();
|
|
}
|
|
|
|
protected function buildApplicationCrumbs() {
|
|
$crumbs = parent::buildApplicationCrumbs();
|
|
|
|
$engine = $this->getEngine();
|
|
if ($engine) {
|
|
$parent = $engine->getParentProject();
|
|
$milestone = $engine->getMilestoneProject();
|
|
if ($parent || $milestone) {
|
|
$id = nonempty($parent, $milestone)->getID();
|
|
$crumbs->addTextCrumb(
|
|
pht('Subprojects'),
|
|
$this->getApplicationURI("subprojects/{$id}/"));
|
|
}
|
|
}
|
|
|
|
return $crumbs;
|
|
}
|
|
|
|
}
|