1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-07 13:21:02 +01:00
phorge-phorge/src/applications/diffusion
epriestley 7cbbe2ccf7 When users browse to a submodule path in Diffusion explicitly, don't fatal
Summary: Ref T13030. See PHI254. This behavior could be cleaner than I've made it, but it fixes the "this is totally broken" issue, replacing a fatal/exception with an informative (just not terribly useful) page.

Test Plan:
  - Added a submodule to a repository.
  - In Diffusion, clicked some other file next to the submodule, then edited the URI to the submodule path instead.
    - Before patch: fatal.
    - After patch: relatively useful message about this being a submodule.

Note that it's normally hard to hit this URI directly. In the browse view, submodules are marked up as directories and linked to a separate submodule resolution flow.

{F5321524}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13030

Differential Revision: https://secure.phabricator.com/D18831
2017-12-18 09:18:22 -08:00
..
application Add a "/source/..." URI for Diffusion commits which redirects 2017-10-03 13:27:03 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit When users browse to a submodule path in Diffusion explicitly, don't fatal 2017-12-18 09:18:22 -08:00
config Move the Git LFS gate to dedicated (non-prototype) config 2017-12-18 09:12:22 -08:00
controller Restore the "Download from Git LFS" UI button to Diffusion 2017-12-18 09:13:19 -08:00
data When users browse to a submodule path in Diffusion explicitly, don't fatal 2017-12-18 09:18:22 -08:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Expose the commit/task/revision relationship edges to "edge.search" 2017-04-02 19:49:55 -07:00
editor Fix several safety issues with repository URIs 2017-11-30 14:06:21 -08:00
engine Fix spelling 2017-10-09 10:48:04 -07:00
engineextension Modernize QuickSearch typeahead 2017-11-30 15:07:49 +00:00
exception Filter and reject "--config" and "--debugger" flags to Mercurial in any position 2017-11-10 08:42:07 -08:00
garbagecollector Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
gitlfs Fix spelling 2017-10-09 10:48:04 -07:00
herald Add a Herald pre-commit field for detecting LFS usage 2017-12-18 09:12:52 -08:00
management Update Repository Management pages to new fixed UI 2017-09-05 19:01:27 -07:00
panel Update VCS password UI 2017-09-07 15:50:05 -07:00
protocol Filter and reject "--config" and "--debugger" flags to Mercurial in any position 2017-11-10 08:42:07 -08:00
query Filter and reject "--config" and "--debugger" flags to Mercurial in any position 2017-11-10 08:42:07 -08:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup When commits have a "rewritten" hint, try to show that in handles in other applications 2016-08-24 09:35:19 -07:00
request Add profile images to Repositories 2017-06-12 07:51:39 -07:00
response Implement a Git LFS server which supports no operations 2016-03-17 08:08:43 -07:00
ssh Improve error messages for running git clone against a Mercurial repository 2016-12-02 07:30:03 -08:00
symbol Extend from Phobject 2015-06-15 18:02:27 +10:00
typeahead Fix an issue where repositories with hyphens could sort improperly in typeaheads 2017-07-03 09:28:02 -07:00
view When users browse to a submodule path in Diffusion explicitly, don't fatal 2017-12-18 09:18:22 -08:00
xaction Fix spelling 2017-10-09 10:48:04 -07:00
DiffusionLintSaveRunner.php Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00