1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/diffusion
epriestley c55de86f0e Return Diffusion diffs through Files, not directly over Conduit
Summary:
Fixes T10423. Ref T11524. This changes `diffusion.rawdiffquery` to return a file PHID instead of a blob of data.

This is better in general, but particularly better for huge diffs (as in T10423) and diffs with non-utf8 data (as in T10423).

Test Plan:
  - Used `bin/differential extract` to extract a latin1 diff, got a clean diff.
  - Used `bin/repository reparse --herald` to rerun herald on a latin1 diff, got a clean result.
  - Pushed latin1 diffs to test commit hooks.
  - Triggered the the too large / too slow logic.
  - Viewed latin1 diffs in Diffusion.
  - Used "blame past this change" in Diffusion to hit the `before` logic.

Reviewers: chad

Reviewed By: chad

Subscribers: eadler

Maniphest Tasks: T10423, T11524

Differential Revision: https://secure.phabricator.com/D16460
2016-08-27 09:11:03 -07:00
..
application Sort out EditController / ManageController / EditproController Diffusion hierarchy 2016-05-10 05:14:09 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
controller Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
data Don't track "phabricator/" staging area tags 2016-06-16 11:22:02 -07:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Fix reverting commit language 2015-06-01 09:54:30 +10:00
editor Fix an issue with creating new Repository URIs via the Web UI 2016-07-09 05:55:45 -07:00
engine Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
engineextension Fix an issue with URI index updates from the daemons 2016-05-13 06:51:31 -07:00
exception Make repository daemon locks more granular and forgiving 2016-05-13 05:17:27 -07:00
garbagecollector Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
gitlfs Implement a Git LFS link table and basic batch API 2016-03-17 17:15:20 -07:00
herald Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
management Version clustered, observed repositories in a reasonable way (by largest discovered HEAD) 2016-05-30 09:53:01 -07:00
panel Allow administrators to configure global default settings 2016-06-05 13:15:06 -07:00
protocol Fix a bad DiffusionCommandEngine parameter from HTTPEngine conversion 2016-08-11 16:41:09 -07:00
query Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup When commits have a "rewritten" hint, try to show that in handles in other applications 2016-08-24 09:35:19 -07:00
request Rough sketch of new repository URI editing 2016-04-29 09:21:00 -07:00
response Implement a Git LFS server which supports no operations 2016-03-17 08:08:43 -07:00
ssh Fix improper viewer for Git SSH cluster workflows 2016-05-11 18:02:02 -07:00
symbol Extend from Phobject 2015-06-15 18:02:27 +10:00
typeahead Render browse results with global result style 2016-06-20 16:49:02 -07:00
view Build that thing someone posted a screenshot of on Facebook 2016-07-01 04:36:24 -07:00
DiffusionLintSaveRunner.php Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00