1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley 7d0d6fbcf2 Consolidate changeset rendering logic
Summary:
Ref T5179. Currently, all the changeset rendering logic is in the "populate" behavior, and a lot of it comes in via configuration and is hard to get at.

Instead, surface an object which can control it, and which other behaviors can access more easily.

In particular, this allows us to add a "Load/Reload" item to the view options menu, which would previously have been very challenging.

Load/Reload isn't useful on its own, but is a step away from "Show whitespace as...", "Highlight as...", "Show tabtops as...", "View Unified", "View Side-By-Side", etc.

Test Plan:
  - Viewed Differential.
  - Viewed Diffusion.
  - Viewed large changesets, clicked "Load".
  - Used "Load" and "Reload" from view options menu.
  - Loaded all changes in a large diff, verified "Load" and TOC clicks take precedence over other content loads.
  - Played with content stability stuff.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5179

Differential Revision: https://secure.phabricator.com/D9286
2014-06-03 18:01:18 -07:00
..
aphlict Allow the notifications from Aphlict debug messages to expire. 2014-05-30 09:48:13 -07:00
auth Add Persona auth provider 2013-10-14 14:34:57 -07:00
config Various linter fixes. 2014-02-26 12:44:58 -08:00
conpherence Use ActionList-based dropdowns in Conpherence 2014-05-05 10:56:38 -07:00
countdown Various linter fixes. 2014-02-26 12:44:58 -08:00
dashboard Dashboards - add remove functionality 2014-05-19 14:04:26 -07:00
differential Consolidate changeset rendering logic 2014-06-03 18:01:18 -07:00
diffusion Add a SublimeText-style repository typeahead 2014-05-13 14:08:21 -07:00
doorkeeper Various linter fixes. 2014-02-26 12:44:58 -08:00
files Various linter fixes. 2014-02-26 12:44:58 -08:00
harbormaster Various linter fixes. 2014-02-26 12:44:58 -08:00
herald Herald - make tokenizers have the purdy icons 2014-04-10 12:38:15 -07:00
maniphest Despecialize most task status handling 2014-03-25 13:47:42 -07:00
owners Allow excluding paths from package 2012-12-07 16:33:16 -08:00
passphrase Add "allow null" and username hinting to the Passphrase credential control 2013-11-22 14:35:35 -08:00
phame Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
pholio Pholio - back end for image re-ordering 2013-08-12 13:09:07 -07:00
phortune Allow PhortuneTestProvider to add payment methods 2013-04-25 09:50:08 -07:00
policy [redesign] Tokens and List 2014-05-28 20:58:22 -07:00
ponder Use PHUIRemarkupPreviewPanel in Ponder 2013-08-05 10:47:06 -07:00
projects Allow workboards to be filtered with ApplicationSearch 2014-05-20 11:42:05 -07:00
releeph Use standard UI elements to render pull requests in Releeph 2014-04-18 06:44:45 -07:00
repository Removed getElementsByClassName in repositor-crossreference.js 2013-05-12 06:54:15 -07:00
search Various linter fixes. 2014-02-26 12:44:58 -08:00
slowvote Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
transactions Move all comment management junk into a dropdown menu 2014-05-05 10:57:23 -07:00
uiexample Fix more JavelinView example stuff 2013-07-16 13:46:49 -07:00