mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 08:12:40 +01:00
6302414883
Summary: Fixes T4985, add manage page, change view page to show only panels. Arguably, PhabricatorDashboardArrangeController is no longer necessary. Also, still trying to figure out if I updated all flows that involve "arrange/{id}". Probably missed some. Also not sure of the Manage Dashboard icon. Please advise. Test Plan: Create dashboard, add panels, "view/{id}" should show just panels, Manage Dashboard should show timeline and edit links. Reviewers: #blessed_reviewers, epriestley, chad Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4985 Differential Revision: https://secure.phabricator.com/D9258
193 lines
5.5 KiB
PHP
193 lines
5.5 KiB
PHP
<?php
|
|
|
|
final class PhabricatorDashboardPanelEditController
|
|
extends PhabricatorDashboardController {
|
|
|
|
private $id;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = idx($data, 'id');
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$viewer = $request->getUser();
|
|
|
|
if ($this->id) {
|
|
$is_create = false;
|
|
|
|
$panel = id(new PhabricatorDashboardPanelQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($this->id))
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->executeOne();
|
|
if (!$panel) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
} else {
|
|
$is_create = true;
|
|
|
|
$panel = PhabricatorDashboardPanel::initializeNewPanel($viewer);
|
|
|
|
$types = PhabricatorDashboardPanelType::getAllPanelTypes();
|
|
$type = $request->getStr('type');
|
|
if (empty($types[$type])) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
$panel->setPanelType($type);
|
|
}
|
|
|
|
if ($is_create) {
|
|
$title = pht('New Panel');
|
|
$header = pht('Create New Panel');
|
|
$button = pht('Create Panel');
|
|
$cancel_uri = $this->getApplicationURI('panel/');
|
|
} else {
|
|
$title = pht('Edit %s', $panel->getMonogram());
|
|
$header = pht('Edit %s %s', $panel->getMonogram(), $panel->getName());
|
|
$button = pht('Save Panel');
|
|
$cancel_uri = $this->getPanelRedirectURI($panel);
|
|
}
|
|
|
|
$v_name = $panel->getName();
|
|
$e_name = true;
|
|
|
|
$field_list = PhabricatorCustomField::getObjectFields(
|
|
$panel,
|
|
PhabricatorCustomField::ROLE_EDIT);
|
|
$field_list
|
|
->setViewer($viewer)
|
|
->readFieldsFromStorage($panel);
|
|
|
|
$validation_exception = null;
|
|
|
|
if ($request->isFormPost()) {
|
|
$v_name = $request->getStr('name');
|
|
$v_view_policy = $request->getStr('viewPolicy');
|
|
$v_edit_policy = $request->getStr('editPolicy');
|
|
|
|
$type_name = PhabricatorDashboardPanelTransaction::TYPE_NAME;
|
|
$type_view_policy = PhabricatorTransactions::TYPE_VIEW_POLICY;
|
|
$type_edit_policy = PhabricatorTransactions::TYPE_EDIT_POLICY;
|
|
|
|
$xactions = array();
|
|
|
|
$xactions[] = id(new PhabricatorDashboardPanelTransaction())
|
|
->setTransactionType($type_name)
|
|
->setNewValue($v_name);
|
|
|
|
$xactions[] = id(new PhabricatorDashboardPanelTransaction())
|
|
->setTransactionType($type_view_policy)
|
|
->setNewValue($v_view_policy);
|
|
|
|
$xactions[] = id(new PhabricatorDashboardPanelTransaction())
|
|
->setTransactionType($type_edit_policy)
|
|
->setNewValue($v_edit_policy);
|
|
|
|
$field_xactions = $field_list->buildFieldTransactionsFromRequest(
|
|
new PhabricatorDashboardPanelTransaction(),
|
|
$request);
|
|
$xactions = array_merge($xactions, $field_xactions);
|
|
|
|
try {
|
|
$editor = id(new PhabricatorDashboardPanelTransactionEditor())
|
|
->setActor($viewer)
|
|
->setContinueOnNoEffect(true)
|
|
->setContentSourceFromRequest($request)
|
|
->applyTransactions($panel, $xactions);
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI($this->getPanelRedirectURI($panel));
|
|
} catch (PhabricatorApplicationTransactionValidationException $ex) {
|
|
$validation_exception = $ex;
|
|
|
|
$e_name = $validation_exception->getShortMessage($type_name);
|
|
|
|
$panel->setViewPolicy($v_view_policy);
|
|
$panel->setEditPolicy($v_edit_policy);
|
|
}
|
|
}
|
|
|
|
$policies = id(new PhabricatorPolicyQuery())
|
|
->setViewer($viewer)
|
|
->setObject($panel)
|
|
->execute();
|
|
|
|
$form = id(new AphrontFormView())
|
|
->setUser($viewer)
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setLabel(pht('Name'))
|
|
->setName('name')
|
|
->setValue($v_name)
|
|
->setError($e_name))
|
|
->appendChild(
|
|
id(new AphrontFormPolicyControl())
|
|
->setName('viewPolicy')
|
|
->setPolicyObject($panel)
|
|
->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
|
|
->setPolicies($policies))
|
|
->appendChild(
|
|
id(new AphrontFormPolicyControl())
|
|
->setName('editPolicy')
|
|
->setPolicyObject($panel)
|
|
->setCapability(PhabricatorPolicyCapability::CAN_EDIT)
|
|
->setPolicies($policies));
|
|
|
|
$field_list->appendFieldsToForm($form);
|
|
|
|
$form
|
|
->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->setValue($button)
|
|
->addCancelButton($cancel_uri));
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addTextCrumb(
|
|
pht('Panels'),
|
|
$this->getApplicationURI('panel/'));
|
|
if ($is_create) {
|
|
$crumbs->addTextCrumb(pht('New Panel'));
|
|
$form->addHiddenInput('type', $panel->getPanelType());
|
|
} else {
|
|
$crumbs->addTextCrumb(
|
|
$panel->getMonogram(),
|
|
'/'.$panel->getMonogram());
|
|
$crumbs->addTextCrumb(pht('Edit'));
|
|
}
|
|
|
|
$box = id(new PHUIObjectBoxView())
|
|
->setHeaderText($header)
|
|
->setValidationException($validation_exception)
|
|
->setForm($form);
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$box,
|
|
),
|
|
array(
|
|
'title' => $title,
|
|
'device' => true,
|
|
));
|
|
}
|
|
|
|
private function getPanelRedirectURI(PhabricatorDashboardPanel $panel) {
|
|
$request = $this->getRequest();
|
|
$dashboard_id = $request->getInt('dashboardID');
|
|
if ($dashboard_id) {
|
|
$uri = $this->getApplicationURI('manage/'.$dashboard_id.'/');
|
|
} else {
|
|
$uri = '/'.$panel->getMonogram();
|
|
}
|
|
|
|
return $uri;
|
|
}
|
|
|
|
}
|