mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 22:10:55 +01:00
No description
7f5b15c6fa
Summary: Currently, the linter raises `XHP29` warnings for these files because they are not abstract or final. I guess there are two possibly solutions, either making the classes final or marking them as `@concrete-extensible`. Given that there are no subclasses of these classes in the `phabricator`, `arcanist` and `libphutil` repositories... I opted to declare the classes as final. Test Plan: The following linter warnings are gone: ``` >>> Lint for src/aphront/configuration/AphrontDefaultApplicationConfiguration.php: Warning (XHP29) Class Not abstract Or final This class is neither 'final' nor 'abstract', and does not have a docblock marking it '@concrete-extensible'. 3 /** 4 * @group aphront 5 */ >>> 6 class AphrontDefaultApplicationConfiguration 7 extends AphrontApplicationConfiguration { 8 9 public function __construct() { >>> Lint for src/applications/differential/mail/DifferentialReplyHandler.php: Warning (XHP29) Class Not abstract Or final This class is neither 'final' nor 'abstract', and does not have a docblock marking it '@concrete-extensible'. 1 <?php 2 >>> 3 class DifferentialReplyHandler extends PhabricatorMailReplyHandler { 4 5 private $receivedMail; 6 ``` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D8347 |
||
---|---|---|
bin | ||
conf | ||
externals | ||
resources | ||
scripts | ||
src | ||
support | ||
webroot | ||
.arcconfig | ||
.divinerconfig | ||
.editorconfig | ||
.gitignore | ||
LICENSE | ||
NOTICE | ||
README |
Phabricator is an open source collection of web applications which help software companies build better software. Phabricator includes applications for: - reviewing and auditing source code; - hosting and browsing repositories; - assembling a party to venture forth; - tracking bugs; - hiding stuff from coworkers; and - also some other things. You can learn more about the project (and find links to documentation and resources) here: http://phabricator.org/ Phabricator is developed and maintained by Phacility. The first version of Phabricator was originally built at Facebook. LICENSE Phabricator is released under the Apache 2.0 license except as otherwise noted.