1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src
epriestley 7f6fa28363 When loading packages affected by a change to a particular path, ignore archived packages
Summary:
Ref T11650. Currently, we load packages and then discard the archived ones.

However, this gets "dominion" rules (where a more-general package gives up ownership if a more-specific package exists) wrong if the more-specific package is archived: we incorrectly give up ownership.

Instead, just ignore these packages completely when loading affected packages. This is slightly simpler.

(There are technically two pieces of code we have to do this for, which should be a single piece of code but which haven't yet been unified.)

Test Plan:
  - Created packages:
    - Package A, on "/" (strong dominion, autoreview).
    - Package B, on "/x/" (weak dominion, autoreview).
    - Package C, on "/x/y" (archived, autoreview).
  - Create a revision affecting "/x/y".
  - Saw correct path ownership in table of contents ("B", strongest package only).
  - Saw correct autoreview behavior (A + B).
  - (Prior to patch, in `master`, reproduced the problem behaviors described in T11650, with bad dominion rules and failure to autoreview B.)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11650

Differential Revision: https://secure.phabricator.com/D16564
2016-09-16 14:02:53 -07:00
..
__tests__
aphront Raise setup warnings immediately when failing to load configuration from the database 2016-09-06 14:20:31 -07:00
applications When loading packages affected by a change to a particular path, ignore archived packages 2016-09-16 14:02:53 -07:00
docs Fix myranch TLD 2016-09-09 03:55:11 -07:00
extensions
infrastructure Add a specialized cache for storing "has setup ever worked?" 2016-09-12 08:04:32 -07:00
view Clean up some Conpherence header CSS 2016-09-14 21:13:25 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Add an "Export as .ics" action to Calendar events 2016-09-14 19:07:52 -07:00