mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 22:10:55 +01:00
7f91c8c4ac
Summary: Depends on D18805. Ref T13025. Fixes T10268. Instead of using a list of IDs for the bulk editor, power it with SearchEngine queries. This gives us the full power of SearchEngine and lets us use a query key instead of a list of 20,000 IDs to avoid issues with URL lengths. Also, split it into a base `BulkEngine` and per-application subclasses. This moves us toward T10005 and universal support for bulk operations. Also: - Renames most of "batch" to "bulk": we're curently inconsitent about this, I like "bulk" better since I think it's more clear if you don't regularly interact with `.bat` files, and newer stuff mostly uses "bulk". - When objects in the result set can't be edited because you don't have permission, show the status more clearly. This probably breaks some stuff a bit since I refactored so heavily, but it seems mostly OK from poking around. I'll clean up anything I missed in followups to deal with remaining items on T13025. Test Plan: {F5302300} - Bulk edited from Maniphest. - Bulk edited from a workboard (no more giant `?ids=....` in the URL). - Hit most of the error conditions, I think? - Clicked the "Cancel" button. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13025, T10268 Differential Revision: https://secure.phabricator.com/D18806 |
||
|---|---|---|
| .. | ||
| button | ||
| calendar | ||
| object-item | ||
| workboards | ||
| phui-action-list.css | ||
| phui-action-panel.css | ||
| phui-badge.css | ||
| phui-basic-nav-view.css | ||
| phui-big-info-view.css | ||
| phui-box.css | ||
| phui-chart.css | ||
| phui-cms.css | ||
| phui-comment-form.css | ||
| phui-comment-panel.css | ||
| phui-crumbs-view.css | ||
| phui-curtain-view.css | ||
| phui-document-pro.css | ||
| phui-document-summary.css | ||
| phui-document.css | ||
| phui-feed-story.css | ||
| phui-fontkit.css | ||
| phui-form-view.css | ||
| phui-form.css | ||
| phui-head-thing.css | ||
| phui-header-view.css | ||
| phui-hovercard.css | ||
| phui-icon-set-selector.css | ||
| phui-icon.css | ||
| phui-image-mask.css | ||
| phui-info-view.css | ||
| phui-invisible-character-view.css | ||
| phui-left-right.css | ||
| phui-lightbox.css | ||
| phui-list.css | ||
| phui-object-box.css | ||
| phui-pager.css | ||
| phui-pinboard-view.css | ||
| phui-property-list-view.css | ||
| phui-remarkup-preview.css | ||
| phui-segment-bar-view.css | ||
| phui-spacing.css | ||
| phui-status.css | ||
| phui-tag-view.css | ||
| phui-timeline-view.css | ||
| phui-two-column-view.css | ||