revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 02:12:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/webroot/rsrc/js/application/diff
History
epriestley 8692d673c8 Fix minor inline comment header button behaviors 
Summary:
Fixes T12806. Ref T12733.

  - Don't count synthetic (lint) comments as anything.
  - When you begin writing an inline then cancel it, don't count it as anything.
  - When we would show "0 / X", just show "X".

Test Plan:
  - Viewed a diff with synthetic comments, no button.
  - Wrote, then cancelled an inline. No "X comments".
  - Clicked / unlicked "Done", saw "X" -> "1 / X".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12806, T12733

Differential Revision: https://secure.phabricator.com/D18103
2017-06-07 19:10:12 -07:00
..
behavior-preview-link.js Make "View" links on Differential inline comment previews work again 2017-01-02 13:24:02 -08:00
DiffChangeset.js Add "X / Y Comments" button to Differential persistent header 2017-06-05 09:49:27 -07:00
DiffChangesetList.js Fix minor inline comment header button behaviors 2017-06-07 19:10:12 -07:00
DiffInline.js Fix minor inline comment header button behaviors 2017-06-07 19:10:12 -07:00