1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/infrastructure/diff
epriestley 8052ab84bf Remove "^" (Prev) and "V" (Next) actions on Differential inline comments
Summary:
Ref T12616. Fixes T12715. I suspect these are very rarely used. (I think you tried to get rid of them before but I pushed back since we couldn't really offer great alternatives at the time?)

Now that the code is in a better place:

  - Click an inline's header (just the colored part) to select it with the keyboard selection cursor.
  - Click again to deselect it.
  - You can use "n" and "p" to jump to comments, so "click + n" is the same as the old "V" action.
  - This also makes it easier to swap between keyboard and mouse workflows, since you can jump into things with the keyboard at any inline.

Also, make "Reply" render more consistently.

Test Plan:
  - Did all that stuff, things seemed to work OK.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12715, T12616

Differential Revision: https://secure.phabricator.com/D17908
2017-05-16 09:44:00 -07:00
..
interface Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
query Publish draft "done" status when submitting comments/updates/actions/inlines 2015-03-24 05:26:12 -07:00
view Remove "^" (Prev) and "V" (Next) actions on Differential inline comments 2017-05-16 09:44:00 -07:00
PhabricatorChangesetResponse.php Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
PhabricatorDifferenceEngine.php Extend from Phobject 2015-06-15 18:02:27 +10:00
PhabricatorInlineCommentController.php Move inline replies to new code and remove DifferentialInlineEditor 2017-05-16 06:23:51 -07:00
PhabricatorInlineCommentPreviewController.php Touch up PHP/JS interactions for inline comments 2015-03-27 17:08:31 -07:00