1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
phorge-phorge/src/infrastructure
epriestley aaab1011e5 Give AphrontTagView a getViewer(), deprecate getUser()
Summary:
Two minor changes here:

  - Replace `get/setUser()` with `get/setViewer()` for consistency with everything else.
  - `getViewer()` now throws if no viewer is set. We had a lot of code that either "should" check this but didn't, or did check it in an identical way, duplicating work. In contrast, very little code checks for a viewer but works if one is not present.

Test Plan:
  - Grepped for `->user`.
  - Attempted to fix all callsites inside `*View` classes.
  - Browsed around a bunch of applications, particularly Calendar, Differential and Diffusion, which seemed most heavily affected.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15412
2016-03-06 09:27:38 -08:00
..
customfield Convert DrydockBlueprints to EditEngine 2016-03-03 15:21:25 -08:00
daemon Remove shouldShowSubscribersProperty() from SubscribableInterface 2016-03-06 06:01:36 -08:00
diff Give AphrontTagView a getViewer(), deprecate getUser() 2016-03-06 09:27:38 -08:00
edges Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
env Remove daemon envHash and envInfo 2015-11-11 08:54:45 +11:00
events Modernize Hovercard implementation 2015-12-24 12:18:28 -08:00
internationalization Fix a couple of missing translation strings 2016-02-12 08:10:10 -08:00
javelin Extend from Phobject 2015-06-15 18:02:27 +10:00
lint/linter Linter fixes 2015-12-03 07:44:23 +11:00
log Extend from Phobject 2015-06-15 18:02:27 +10:00
management Add some of a billing daemon skeleton 2015-01-30 11:29:05 -08:00
markup Always install the "icon" and "emoji" remarkup rules 2016-02-19 11:51:53 -08:00
query Fix an issue with paginating queries which reverse vector ordering components 2016-01-21 11:11:24 -08:00
sms Various linter fixes 2015-08-11 22:36:55 +10:00
ssh phtize all the things 2015-05-22 21:16:39 +10:00
storage Throw a more tailored error when a storage upgrade patch can't access a database 2016-01-21 14:54:56 -08:00
testing Fix a possible deadlock in unit tests after an error 2015-12-24 09:11:47 -08:00
time Extend from Phobject 2015-06-15 18:02:27 +10:00
util Improve error messages for bad hashtags and project names 2015-12-24 08:11:02 -08:00
PhabricatorEditor.php Mark some strings for translation 2015-06-09 23:06:52 +10:00