epriestley a5903d2a53 Use head_key() and last_key() to explicitly communicate intent ... Summary: PHP arrays have an internal "current position" marker. (I think because foreach() wasn't introduced until PHP 4 and there was no way to get rid of it by then?) A few functions affect the position of the marker, like reset(), end(), each(), next(), and prev(). A few functions read the position of the marker, like each(), next(), prev(), current() and key(). For the most part, no one uses any of this because foreach() is vastly easier and more natural. However, we sometimes want to select the first or last key from an array. Since key() returns the key //at the current position//, and you can't guarantee that no one will introduce some next() calls somewhere, the right way to do this is reset() + key(). This is cumbesome, so we introduced head_key() and last_key() (like head() and last()) in D2161. Switch all the reset()/end() + key() (or omitted reset() since I was feeling like taking risks + key()) calls to head_key() or last_key(). Test Plan: Verified most of these by visiting the affected pages. Reviewers: btrahan, vrana, jungejason, Koolvin Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2169		2012-04-09 11:08:59 -07:00
..
base	General Herald refactoring pass	2012-03-30 10:49:55 -07:00
delete	Minor, jumped the gun on review feedback in D2040.	2012-03-30 10:50:38 -07:00
edithistory	General Herald refactoring pass	2012-03-30 10:49:55 -07:00
home	Use head_key() and last_key() to explicitly communicate intent	2012-04-09 11:08:59 -07:00
new	Use head_key() and last_key() to explicitly communicate intent	2012-04-09 11:08:59 -07:00
rule	Allow users to add flags via Herald rules	2012-03-30 13:51:54 -07:00
test	General Herald refactoring pass	2012-03-30 10:49:55 -07:00
transcript	Allow users to add flags via Herald rules	2012-03-30 13:51:54 -07:00
transcriptlist	General Herald refactoring pass	2012-03-30 10:49:55 -07:00