1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc
Sergey Sharybin 83ab275b0f Fix JavaScript exception when having users with special names
Summary:
The issue was noticed in Firefox when user with login "watch"
was registered in the database. And it was caused by Object
in Firefox having "watch" method.

Solved by checking for whether lookup object does have own
property before using it as a map key.

Test Plan:
To test the issue simply create a user with login "watch",
open the phabricator site in Firefox and try to assign any
maniphest task to this user. You'll see exception being
printed to the javascript console (in my case it's printed
to firebug console).

Reviewers: #blessed_reviewers, epriestley

Reviewed By: epriestley

CC: epriestley, aran

Differential Revision: https://secure.phabricator.com/D8037
2014-01-22 09:10:30 -08:00
..
css Awesomify dragging stuff on workboards 2014-01-21 14:26:05 -08:00
externals Fix JavaScript exception when having users with special names 2014-01-22 09:10:30 -08:00
image Use more common styles for setup issue CSS 2014-01-18 08:31:47 -08:00
js Send appropriate requests to the server when dragging cards on project boards 2014-01-13 12:24:36 -08:00
swf Remove spurious "+x" from files that shouldn't have it 2013-10-05 05:18:17 -07:00