1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00
phorge-phorge/src/applications/meta
Andre Klapper 3819f7ff19 Fix PHP 8.1 "ltrim(null)" exception which blocks rendering five applications' Configure pages
Summary:
Since PHP 8.1, passing a null string to `ltrim(string $string, string $characters)` is deprecated.

Thus do not check for `$path = null` but check for `$path = ''` before passing `$path` as the `$string` parameter to `ltrim()`, like src/applications/settings/panel/PhabricatorSettingsPanel.php already does.

Closes T15359

Test Plan: Applied this change (on top of D25197) and five applications' Configure pages (Differential, Maniphest, Files, Paste, and Ponder) finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15359

Differential Revision: https://we.phorge.it/D25198
2023-05-08 14:33:43 +02:00
..
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
controller Fix PHP 8.1 "strlen(null)" exception which blocks rendering most applications' Configure pages 2023-05-08 13:23:31 +02:00
editor Implement modular transactions for application policy changes 2017-05-03 17:49:41 -07:00
engineextension Fix fatal during redirection safety check for searching for Phabricator base-uri with no trailing slash 2019-09-09 12:45:24 -07:00
panel Fix PHP 8.1 "ltrim(null)" exception which blocks rendering five applications' Configure pages 2023-05-08 14:33:43 +02:00
phid Give application actors in feed reasonable icons 2016-04-20 14:38:55 -07:00
query Fix numerous PHP 8.1 "strlen(null)" exceptions which block rendering the Applications page 2023-05-01 15:34:32 +02:00
storage Implement modular transactions for application policy changes 2017-05-03 17:49:41 -07:00
typeahead Check if app is installed for user before displying 2016-09-07 22:42:20 -04:00
xactions Fix a straggling callsite to "renderApplicationPolicy()" 2019-09-12 16:26:57 -07:00