1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 19:02:41 +01:00
phorge-phorge/src/infrastructure
epriestley 03ebbccbc9 Restore image proxying to Remarkup
Summary:
Previously, Remarkup allowed you to paste in an image URI and get an inline
image. However, it did this by hotlinking the image which isn't so hot in an
open source product.

Restore this feature, but use image proxying instead. The existing image macro
code does most of the work.

There is a mild security risk depending on the network setup so I've left this
default-disabled and made a note about it. It should be safe to enable for
Facebook.

Test Plan:
Pasted in image and non-image links, got reasonable behavior. Verified proxying
appears to work. Verified that file:// shenanigans produce 400.

Reviewed By: tuomaspelkonen
Reviewers: aran, jungejason, tuomaspelkonen
Commenters: cpiro
CC: aran, cpiro, tuomaspelkonen
Differential Revision: 214
2011-05-03 18:49:06 -07:00
..
celerity PhabricatorEnv 2011-01-31 11:55:26 -08:00
daemon Enable phd to load extra libraries 2011-04-15 18:57:03 -07:00
env Correct a mask config value 2011-04-30 11:56:16 -07:00
javelin Rought cut of search. 2011-02-14 15:34:20 -08:00
markup/remarkup/markuprule Restore image proxying to Remarkup 2011-05-03 18:49:06 -07:00
testing/testcase Provide connection isolation to Lisk and enable it by default in tests 2011-04-30 22:24:50 -07:00