1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/src
epriestley 8476ad1a28 Separate all commit message field parsing out of Differential custom fields
Summary:
Ref T11114. See that task for some discussion.

Overall, Differential custom fields ended up with too many responsibilities. Later work in EditEngine provides a more promising model for achieving modularity with smaller, more consistent components.

In particular, we have some custom fields like `DifferentialGitSVNIDField` and `DifferentialConflictsField` which serve //only// to support the field parser.

This starts pulling commit message responsibilities out of the core list of custom fields and into simpler dedicated parsers.

Test Plan: Created and edited revisions from the CLI. Added a bit of test coverage.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17058
2016-12-14 18:44:14 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Fix an issue where unexpected debugging output would run afoul of automatic compression 2016-12-14 07:27:08 -08:00
applications Separate all commit message field parsing out of Differential custom fields 2016-12-14 18:44:14 -08:00
docs Make the documentation more clear that storage.mysql-engine.max-size is measured in bytes 2016-12-13 07:34:20 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Replace Differential Edit controller with EditEngine-driven EditPro controller 2016-12-14 07:27:39 -08:00
view Reorganize phui-object-item CSS, add drag ui 2016-12-14 11:53:17 -08:00
__phutil_library_init__.php
__phutil_library_map__.php Separate all commit message field parsing out of Differential custom fields 2016-12-14 18:44:14 -08:00