1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-22 18:28:47 +02:00
phorge-phorge/src/applications/harbormaster
James Rhodes fc3b5ddce6 Prevent buildable list in Harbormaster from breaking when container or buildables are missing
Summary: Ref T1049.  I'm fair sure this is just a case of bad data in my local install, but we probably don't want the default page for Harbormaster to break when there's invalid / missing container or buildable handles on any of the builds.

Test Plan: Loaded the page, didn't get a crash due to null reference.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: demo, epriestley, Korvin

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D8608
2014-03-25 17:35:49 -07:00
..
application Don't create invalid build steps while adding them 2014-03-25 16:12:05 -07:00
capability Harbormaster v(-2) 2013-10-22 15:01:06 -07:00
conduit Allow external systems to send messages to build targets 2014-03-25 16:11:28 -07:00
config Migrate "Run Command" to use Drydock hosts 2013-12-05 14:06:22 +11:00
controller Prevent buildable list in Harbormaster from breaking when container or buildables are missing 2014-03-25 17:35:49 -07:00
customfield Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
editor Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00
engine Delete artifacts when restarting build 2014-01-28 20:17:36 -08:00
event Replace "Cancel Build" with "Stop", "Resume" and "Restart" 2014-01-06 12:32:20 -08:00
interface Add bin/harbormaster to make builds easier to debug 2013-12-26 10:40:52 -08:00
management Extend all "ManagementWorkflow" classes from a base class 2013-12-27 13:15:40 -08:00
phid Render build status on revisions and commits 2013-11-09 15:04:00 -08:00
query Allow external systems to send messages to build targets 2014-03-25 16:11:28 -07:00
remarkup Harbormaster v(-2) 2013-10-22 15:01:06 -07:00
step Make various minor Harbormaster UI improvements 2014-03-25 16:10:50 -07:00
storage Don't create invalid build steps while adding them 2014-03-25 16:12:05 -07:00
view Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
worker Use ApplicationTransactions and CustomField to implement build steps 2014-03-25 16:08:40 -07:00