1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-04 12:42:43 +01:00
phorge-phorge/src/applications/auth/controller
epriestley 84b5ad09e6 Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount"
Summary:
Depends on D21018. Ref T13493. Ref T6703. The "ExternalAccount" table has a unique key on `<accountType, accountDomain, accountID>` but this no longer matches our model of reality and changes in this sequence end writes to `accountID`.

Remove this key.

Then, remove all readers of `accountType` and `accountDomain` (and all nontrivial writers) because none of these callsites are well-aligned with plans in T6703.

This change has no user-facing impact today: all the rules about linking/unlinking/etc remain unchanged, because other rules currently prevent creation of more than one provider with a given "accountType".

Test Plan:
- Linked an OAuth1 account (JIRA).
- Linked an OAuth2 account (Asana).
- Used `bin/auth refresh` to cycle OAuth tokens.
- Grepped for affected symbols.
- Published an Asana update.
- Published a JIRA link.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13493, T6703

Differential Revision: https://secure.phabricator.com/D21019
2020-02-22 17:48:46 -08:00
..
config When users try to log out with no providers configured, warn them of the consequences 2019-09-08 12:27:29 -07:00
contact Add a "test message" action for contact numbers 2019-01-23 14:22:27 -08:00
message Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both 2019-07-19 15:39:21 -07:00
mfa Fix an issue with Duo not live-updating properly on login gates 2019-03-29 11:00:38 -07:00
PhabricatorAuthConfirmLinkController.php Make external link/refresh use provider IDs, switch external account MFA to one-shot 2019-02-12 15:18:08 -08:00
PhabricatorAuthController.php Remove an ancient no-op check for duplicated external accounts 2020-02-22 17:45:19 -08:00
PhabricatorAuthDowngradeSessionController.php Update Auth for handleRequest 2015-08-01 16:49:27 -07:00
PhabricatorAuthFinishController.php Use Log In vs. Login when it's a verb 2017-08-02 12:26:47 -07:00
PhabricatorAuthInviteController.php Support invites in the registration and login flow 2015-02-11 06:06:28 -08:00
PhabricatorAuthLinkController.php Make external link/refresh use provider IDs, switch external account MFA to one-shot 2019-02-12 15:18:08 -08:00
PhabricatorAuthLoginController.php Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount" 2020-02-22 17:48:46 -08:00
PhabricatorAuthNeedsApprovalController.php Add support for custom "Wait for Approval" instructions 2019-05-16 10:41:52 -07:00
PhabricatorAuthNeedsMultiFactorController.php Allow MFA providers to be deprecated or disabled 2019-01-28 09:29:27 -08:00
PhabricatorAuthOldOAuthRedirectController.php Update Auth for handleRequest 2015-08-01 16:49:27 -07:00
PhabricatorAuthOneTimeLoginController.php When users follow an email login link but an install does not use passwords, try to get them to link an account 2019-02-15 14:41:31 -08:00
PhabricatorAuthRegisterController.php Update unusual handling of external accounts in "Password" auth provider 2020-02-22 17:46:04 -08:00
PhabricatorAuthRevokeTokenController.php Clean up redirect URIs for "Temporary Tokens" and "API Tokens" settings panels 2016-06-28 14:51:04 -07:00
PhabricatorAuthSetExternalController.php When users follow an email login link but an install does not use passwords, try to get them to link an account 2019-02-15 14:41:31 -08:00
PhabricatorAuthSetPasswordController.php Move account passwords to shared infrastructure 2018-01-23 13:43:07 -08:00
PhabricatorAuthSSHKeyController.php Add ViewController and SearchEngine for SSH Public Keys 2016-05-19 09:48:46 -07:00
PhabricatorAuthSSHKeyEditController.php Redirect users back to where they added an SSH Key 2017-08-21 14:02:27 -07:00
PhabricatorAuthSSHKeyGenerateController.php Never generate file download forms which point to the CDN domain, tighten "form-action" CSP 2018-02-28 17:20:12 -08:00
PhabricatorAuthSSHKeyListController.php Add ViewController and SearchEngine for SSH Public Keys 2016-05-19 09:48:46 -07:00
PhabricatorAuthSSHKeyRevokeController.php Add a bin/auth revoke revoker for SSH keys 2018-01-22 15:35:07 -08:00
PhabricatorAuthSSHKeyViewController.php Add a bin/auth revoke revoker for SSH keys 2018-01-22 15:35:07 -08:00
PhabricatorAuthStartController.php Persist login instructions onto flow-specific login pages (username/password and LDAP) 2019-10-24 18:38:15 -07:00
PhabricatorAuthTerminateSessionController.php Upgrade sessions digests to HMAC256, retaining compatibility with old digests 2018-12-13 16:15:38 -08:00
PhabricatorAuthUnlinkController.php Write ExternalAccountIdentifiers when interacting with external authentication providers 2020-02-22 17:46:51 -08:00
PhabricatorAuthValidateController.php Update Auth for handleRequest 2015-08-01 16:49:27 -07:00
PhabricatorDisabledUserController.php Update Auth for new UI 2016-03-31 13:51:12 -07:00
PhabricatorEmailLoginController.php Record account recovery email links in the user activity log and make the mail message reference the log 2019-07-24 07:13:34 -07:00
PhabricatorEmailVerificationController.php Update Auth for new UI 2016-03-31 13:51:12 -07:00
PhabricatorLogoutController.php When users try to log out with no providers configured, warn them of the consequences 2019-09-08 12:27:29 -07:00
PhabricatorMustVerifyEmailController.php Use Log In vs. Login when it's a verb 2017-08-02 12:26:47 -07:00
PhabricatorRefreshCSRFController.php Update Auth for handleRequest 2015-08-01 16:49:27 -07:00