1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-16 00:38:38 +01:00
phorge-phorge/src/applications/auth
epriestley 2cb779575d Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks"
Summary:
Ref T11179. This splits "Edit Blocking Tasks" into two options now that we have more room ("Edit Parent Tasks", "Edit Subtasks").

This also renames "Blocking" tasks to "Subtasks", and "Blocked" tasks to "Parent" tasks. My goals here are:

  - Make the relationship direction more clear: it's more clear which way is up with "parent" and "subtask" at a glance than with "blocking" and "blocked" or "dependent" and "dependency".
  - Align language with "Create Subtask".
  - To some small degree, use more flexible/general-purpose language, although I haven't seen any real confusion here.

Fixes T6815. I think I narrowed this down to two issues:

  - Just throwing a bare exeception (we now return a dialog explicitly).
  - Not killing open transactions when the cyclec check fails (we now kill them).

Test Plan:
  - Edited parent tasks.
  - Edited subtasks.
  - Tried to introduce graph cycles, got a nice error dialog.

{F1697087}

{F1697088}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6815, T11179

Differential Revision: https://secure.phabricator.com/D16166
2016-06-22 11:20:38 -07:00
..
action Rate limit multi-factor actions 2014-04-30 14:30:31 -07:00
application Add ViewController and SearchEngine for SSH Public Keys 2016-05-19 09:48:46 -07:00
capability Auth - add "manage providers" capability 2015-01-12 14:37:58 -08:00
conduit Deactivate SSH keys instead of destroying them completely 2016-05-18 14:54:28 -07:00
constants Support invites in the registration and login flow 2015-02-11 06:06:28 -08:00
controller Split "Edit Blocking Tasks" into "Edit Parent Tasks" and "Edit Subtasks" 2016-06-22 11:20:38 -07:00
data Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
editor Fix minor section formatting mishap in SSH key email 2016-05-19 15:20:19 -07:00
engine Centralize "this is the current user for the request" code 2016-06-07 07:43:50 -07:00
exception Add email invites to Phabricator (logic only) 2015-02-09 16:12:36 -08:00
extension Begin modularizing main menu items 2016-01-04 06:57:09 -08:00
factor Formally modularize MFA/TOTP tokens, provide a module panel for temporary tokens 2016-03-16 09:33:58 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
handler Modularize generation of supplemental login messages 2015-09-04 10:34:39 -07:00
mail Send forced mail on SSH key edits 2016-05-19 15:01:25 -07:00
management Various translation improvements 2015-11-03 07:02:46 +11:00
phid Fix an issue with AuthProviderConfig handles 2016-06-16 06:04:43 -07:00
provider Make auth provider autologin modular and implement it for all OAuth2 adapters 2016-06-06 14:33:09 -07:00
query Use transactions to apply web UI SSH key edits 2016-05-19 15:00:18 -07:00
sshkey Send forced mail on SSH key edits 2016-05-19 15:01:25 -07:00
storage Send forced mail on SSH key edits 2016-05-19 15:01:25 -07:00
tokentype Formally modularize MFA/TOTP tokens, provide a module panel for temporary tokens 2016-03-16 09:33:58 -07:00
view Add ViewController and SearchEngine for SSH Public Keys 2016-05-19 09:48:46 -07:00
worker Send emails for email invites 2015-02-11 06:06:09 -08:00