1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
phorge-phorge/src/applications/notification
epriestley 70d67a3908 Fix the most significant "phantom notification" badness
Summary:
Ref T13124. Ref T13131. Fixes T8953. See PHI512.

When you receieve a notification about an object and then someone hides that object from you (or deletes it), you get a phantom notification which is very difficult to clear.

For now, test that notifications are visible when you open the menu and clear any that are not.

This could be a little more elegant than it is, but the current behavior is very clearly broken. This unbreaks it, at least.

Test Plan:
  - As Alice, configured task stuff to notify me (instead of sending email).
  - As Bailey, added Alice as a subscriber to a task, then commented on it.
  - As Alice, loaded home and saw a notification count. Didn't click it yet.
  - As Bailey, set the task to private.
  - As Alice, clicked the notification bell menu icon.
    - Before change: no unread notifications, bell menu is semi-stuck in a phantom state which you can't clear.
    - After change: bad notifications automatically cleared.

{F5530005}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13131, T13124, T8953

Differential Revision: https://secure.phabricator.com/D19384
2018-04-19 17:24:19 -07:00
..
application Complete modernization of Aphlict configuration 2016-04-14 04:57:00 -07:00
builder Make "No Notifications" setting less broad, and fix a bug with default display behavior 2017-09-13 15:32:46 -07:00
client Deduplicate application-level notifications from Aphlict 2017-04-17 15:55:38 -07:00
config Convert cluster/projects config options to newer modular structure 2017-06-27 12:35:54 -07:00
controller Fix the most significant "phantom notification" badness 2018-04-19 17:24:19 -07:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
feed Desktop Notification support 2015-06-22 13:11:37 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
query Fix the most significant "phantom notification" badness 2018-04-19 17:24:19 -07:00
setup Complete modernization of Aphlict configuration 2016-04-14 04:57:00 -07:00
storage Cache user notification and message counts 2016-06-05 08:52:43 -07:00
view Add an icon to aphlict connection status 2016-10-02 08:17:21 -07:00