1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 07:11:04 +01:00
phorge-phorge/webroot/rsrc/js/application/projects
epriestley 8669c3c0d2 When updating a workboard with "R", send the client visible set with version numbers
Summary:
Depends on D20652. Ref T4900. When the user presses "R", send a list of cards currently visible on the client and their version numbers.

On the server:

  - Compare the client verisons to the server versions so we can skip updates for objects which have not changed. (For now, the client version is always "1" and the server version is always "2", so this doesn't do anything meaningful, and every card is always updated.)
  - Compare the client visible set to the server visible set and "remove" any cards which have been removed from the board.

I believe this means that "R" always puts the board into the right state (except for some issues with client orderings not being fully handled yet). It's not tremendously efficient, but we can make versioning better (using the largest object transaction ID) to improve that and loading the page in the first place doesn't take all that long so even sending down the full visible set shouldn't be a huge problem.

Test Plan:
  - In window A, removed a card from a board.
  - In window B, pressed "R" and saw the removal reflected on the client.
  - (Also added cards, edited cards, etc., and didn't catch anything exploding.)

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T4900

Differential Revision: https://secure.phabricator.com/D20653
2019-07-17 13:16:03 -07:00
..
behavior-project-boards.js Make pressing "R" on your keyboard reload the card state on workboards 2019-07-17 13:11:26 -07:00
behavior-project-create.js Allow commits to be associated with projects and associated goodies 2012-08-08 10:03:41 -07:00
behavior-reorder-columns.js Allow the workboard backlog column to be reordered 2014-08-08 15:50:36 -07:00
WorkboardBoard.js When updating a workboard with "R", send the client visible set with version numbers 2019-07-17 13:16:03 -07:00
WorkboardCard.js Modularize workboard column orders 2019-03-12 13:07:50 -07:00
WorkboardCardTemplate.js When updating a workboard with "R", send the client visible set with version numbers 2019-07-17 13:16:03 -07:00
WorkboardColumn.js When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip 2019-03-25 14:02:10 -07:00
WorkboardController.js Make pressing "R" on your keyboard reload the card state on workboards 2019-07-17 13:11:26 -07:00
WorkboardDropEffect.js When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip 2019-03-25 14:02:10 -07:00
WorkboardHeader.js Modularize workboard column orders 2019-03-12 13:07:50 -07:00
WorkboardHeaderTemplate.js Preview the effects of a drag-and-drop operation on workboards 2019-03-25 13:22:56 -07:00
WorkboardOrderTemplate.js Add an "Sort by Creation Date" filter to workboards and modularize remaining order behaviors 2019-03-12 13:46:49 -07:00