mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 01:02:42 +01:00
869f24bf33
Summary: The older logic was incorrect: - It chose `change.left` for `data.on_right` being true. - 'O' and 'N' mean 'old' and 'new', not 'left' and 'right'. In diff-of-diffs, both sides are 'N'. So, select the changeset ID correctly (pick the right side one for on_right), and select the new file prefix correctly (N for new, O for old). Test Plan: Waved my mouse over some inline comments in a diff-of-diffs, got reasonable-looking reticles. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1076 Differential Revision: https://secure.phabricator.com/D2138 |
||
---|---|---|
.. | ||
css | ||
image | ||
js | ||
swf |