1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/maniphest
epriestley 86b08514ab Merge TYPE_PROJECT_COLUMNS and TYPE_COLUMN transactions into a more general TYPE_COLUMNS transaction
Summary:
Ref T6027. We currently have two different transaction types:

  - `TYPE_PROJECT_COLUMNS` does most of the work, but has a sort of weird structure and isn't really suitable for API use.
  - `TYPE_COLUMN` is this weird, junk transaction which mostly just creates the other transaction.

Merge them into a single higher-level `TYPE_COLUMNS` transaction which works properly and has a sensible structure and comprehensive error checking.

Remaining work here:

  - I've removed the old rendering logic, but not yet added new logic. I need to migrate the old transaction types and add new rendering logic.
  - Although the internal representation is now //suitable// for use in the API, it isn't properly exposed yet.

Test Plan:
  - Created tasks into a column.
  - Ran unit tests.
  - Moved tasks between columns.
  - Will perform additional testing in followups.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6027

Differential Revision: https://secure.phabricator.com/D15634
2016-04-06 09:13:31 -07:00
..
__tests__ Modularize content sources 2016-03-26 11:59:45 -07:00
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
bulk Fix "Add Project" in bulk editor 2015-07-02 14:24:15 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Mention !status explicitly in the documentation for !close 2016-01-05 15:08:52 -08:00
conduit Modularize content sources 2016-03-26 11:59:45 -07:00
config Update Maniphest for PHUITwoColumnView 2016-03-04 17:26:38 -08:00
constants Update Maniphest for PHUITwoColumnView 2016-03-04 17:26:38 -08:00
controller Update Batch Edit and Report pages 2016-04-05 07:24:47 -07:00
edge Modernize Pholio edges 2015-01-02 10:11:41 +11:00
editor Merge TYPE_PROJECT_COLUMNS and TYPE_COLUMN transactions into a more general TYPE_COLUMNS transaction 2016-04-06 09:13:31 -07:00
engineextension Move PhabricatorHovercard to PHUIHovercard 2016-02-03 16:26:30 +00:00
export Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
field Add "and" support to "ref" 2015-05-05 07:14:15 +10:00
herald Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign 2015-12-05 12:39:45 -08:00
httpparametertype Make "Create Subtask" work properly in EditEngine 2015-12-08 14:29:58 -08:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
mail Add Maniphest Task email creator to CCs 2015-09-09 14:07:07 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
policyrule Allow PolicyRules to serve as "Object Policies" 2015-06-13 15:44:38 -07:00
query Introduce "bridged" objects 2016-03-22 15:06:57 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
search Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
storage Merge TYPE_PROJECT_COLUMNS and TYPE_COLUMN transactions into a more general TYPE_COLUMNS transaction 2016-04-06 09:13:31 -07:00
typeahead Allow Maniphest statuses and priorities to be disabled 2015-12-05 11:01:41 -08:00
view Drop "-pro" suffix and "editpro" URIs for EditEngine in Maniphest 2015-12-08 17:56:59 -08:00