1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/transactions
epriestley 86b08514ab Merge TYPE_PROJECT_COLUMNS and TYPE_COLUMN transactions into a more general TYPE_COLUMNS transaction
Summary:
Ref T6027. We currently have two different transaction types:

  - `TYPE_PROJECT_COLUMNS` does most of the work, but has a sort of weird structure and isn't really suitable for API use.
  - `TYPE_COLUMN` is this weird, junk transaction which mostly just creates the other transaction.

Merge them into a single higher-level `TYPE_COLUMNS` transaction which works properly and has a sensible structure and comprehensive error checking.

Remaining work here:

  - I've removed the old rendering logic, but not yet added new logic. I need to migrate the old transaction types and add new rendering logic.
  - Although the internal representation is now //suitable// for use in the API, it isn't properly exposed yet.

Test Plan:
  - Created tasks into a column.
  - Ran unit tests.
  - Moved tasks between columns.
  - Will perform additional testing in followups.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T6027

Differential Revision: https://secure.phabricator.com/D15634
2016-04-06 09:13:31 -07:00
..
application Put inline previews in remarkup textareas 2015-12-22 12:18:28 -08:00
commentaction Support enabling a formal points field in Maniphest 2016-02-08 18:14:44 -08:00
constants Merge TYPE_PROJECT_COLUMNS and TYPE_COLUMN transactions into a more general TYPE_COLUMNS transaction 2016-04-06 09:13:31 -07:00
controller Update EditEngine for two column 2016-03-28 09:18:55 -07:00
edges Modernize remaining edge types 2015-01-03 10:58:20 +11:00
editengine Update Conduit for new UI 2016-04-04 16:39:23 -07:00
editfield Convert DrydockBlueprints to EditEngine 2016-03-03 15:21:25 -08:00
editor Update EditEngine for two column 2016-03-28 09:18:55 -07:00
edittype Improve Conduit type handling for *.edit endpoints 2015-12-16 08:45:46 -08:00
engineextension Smooth out milestone creation workflow 2015-12-29 10:40:28 -08:00
error Route task merges through new editor 2013-09-23 14:32:32 -07:00
exception Mark some strings for translation 2015-06-09 23:06:52 +10:00
feed Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
interface Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
phid Allow ApplicationEditor forms to be reconfigured 2015-11-10 10:24:40 -08:00
query Update EditEngine for two column 2016-03-28 09:18:55 -07:00
replyhandler Modularize content sources 2016-03-26 11:59:45 -07:00
response Various translation improvements 2015-11-03 07:02:46 +11:00
storage Update EditEngine for two column 2016-03-28 09:18:55 -07:00
view Redesign PonderQuestionView 2016-02-23 17:20:07 -08:00
worker Modularize content sources 2016-03-26 11:59:45 -07:00