mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-20 20:40:56 +01:00
4f0f95f7b5
Summary: Ref T1049. Ref T2222. `DifferentialDiff` does not currently have a PHID, but we need it for Harbormaster and ApplicationTransactions. See some discussion in D7501. (I split the SQL into two sections so we can't fail in the middle. At some point, I'd like to do a pass on the migration stuff and get this happening automatically, and also simplify the PatchList.) Test Plan: - Ran `bin/storage upgrade`. - Checked for valid PHIDs in the database. - Used `phid.query` to look up a diff by PHID. - Created a new diff and verified it got a PHID. Reviewers: btrahan, hach-que Reviewed By: btrahan CC: aran, vrana Maniphest Tasks: T2222, T1049 Differential Revision: https://secure.phabricator.com/D7513
47 lines
994 B
PHP
47 lines
994 B
PHP
<?php
|
|
|
|
$diff_table = new DifferentialDiff();
|
|
$conn_w = $diff_table->establishConnection('w');
|
|
|
|
$size = 1000;
|
|
|
|
$row_iter = id(new LiskMigrationIterator($diff_table))->setPageSize($size);
|
|
$chunk_iter = new PhutilChunkedIterator($row_iter, $size);
|
|
|
|
foreach ($chunk_iter as $chunk) {
|
|
$sql = array();
|
|
|
|
foreach ($chunk as $diff) {
|
|
$id = $diff->getID();
|
|
echo "Migrating diff ID {$id}...\n";
|
|
|
|
$phid = $diff->getPHID();
|
|
if (strlen($phid)) {
|
|
continue;
|
|
}
|
|
|
|
$type_diff = DifferentialPHIDTypeDiff::TYPECONST;
|
|
$new_phid = PhabricatorPHID::generateNewPHID($type_diff);
|
|
|
|
$sql[] = qsprintf(
|
|
$conn_w,
|
|
'(%d, %s)',
|
|
$id,
|
|
$new_phid);
|
|
}
|
|
|
|
if (!$sql) {
|
|
continue;
|
|
}
|
|
|
|
foreach (PhabricatorLiskDAO::chunkSQL($sql, ', ') as $sql_chunk) {
|
|
queryfx(
|
|
$conn_w,
|
|
'INSERT IGNORE INTO %T (id, phid) VALUES %Q
|
|
ON DUPLICATE KEY UPDATE phid = VALUES(phid)',
|
|
$diff_table->getTableName(),
|
|
$sql_chunk);
|
|
}
|
|
}
|
|
|
|
echo "Done.\n";
|