epriestley 870b01f2d0 Distinguish between "bad record format" and "bad record value" when validating Trigger rules ... Summary: Depends on D20416. Ref T13269. See D20329. If you try to save an "Assign to" rule with no assignee, we currently replace the control with an "InvalidRule" control that isn't editable. We'd prefer to give you an empty field back and let you pick a different value. Differentiate between "bad record format" (i.e., we can't really do anything with this) and "bad record value" (i.e., everything is structurally fine, you just typed the wrong thing). In the latter case, we still build a properly typed rule for the UI, we just refuse to update storage until you fix the problem. Test Plan: First, hit the original issue and got a nicer UI with a more consistent control width (note full-width error): {F6374205} Then, applied the rest of the patch and got a normal "fix the issue" form state instead of a dead-end: {F6374211} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13269 Differential Revision: https://secure.phabricator.com/D20417		2019-04-17 12:40:55 -07:00
..
map.php	Distinguish between "bad record format" and "bad record value" when validating Trigger rules	2019-04-17 12:40:55 -07:00
packages.php	Remove the ability to drag tasks up and down on (non-Workboard) priority list views	2019-03-12 12:47:36 -07:00