1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 12:12:43 +01:00
phorge-phorge/src/applications/project
epriestley 870b01f2d0 Distinguish between "bad record format" and "bad record value" when validating Trigger rules
Summary:
Depends on D20416. Ref T13269. See D20329.

If you try to save an "Assign to" rule with no assignee, we currently replace the control with an "InvalidRule" control that isn't editable. We'd prefer to give you an empty field back and let you pick a different value.

Differentiate between "bad record format" (i.e., we can't really do anything with this) and "bad record value" (i.e., everything is structurally fine, you just typed the wrong thing). In the latter case, we still build a properly typed rule for the UI, we just refuse to update storage until you fix the problem.

Test Plan:
First, hit the original issue and got a nicer UI with a more consistent control width (note full-width error):

{F6374205}

Then, applied the rest of the patch and got a normal "fix the issue" form state instead of a dead-end:

{F6374211}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13269

Differential Revision: https://secure.phabricator.com/D20417
2019-04-17 12:40:55 -07:00
..
__tests__ When moving cards on workboards, treat before/after cards as optional hints, not strict requirements 2019-03-26 07:45:24 -07:00
application Allow triggers to be attached to and removed from workboard columns 2019-03-25 13:21:26 -07:00
capability Add default View, Edit, and Join Policies to Projects 2014-11-21 11:22:17 -08:00
command Implement a "!projects" mail command 2015-04-01 11:51:51 -07:00
conduit Migrate Project color to modular transactions 2017-05-18 16:46:06 -07:00
config Support subtypes in Projects 2019-01-30 06:17:55 -08:00
constants Allow workboard background colors to be configured 2016-02-16 08:15:12 -08:00
controller Fix some overlooked profile menu construction callsites 2019-04-09 14:47:44 -07:00
customfield Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
edge Replace subscribe/unsubscribe for projects with explicit mail setting 2016-01-19 19:39:02 -08:00
editor Track how many columns use a particular trigger 2019-03-25 14:04:55 -07:00
engine Allow profile menu items to be locked to the top or bottom of the menu 2019-04-02 15:08:20 -07:00
engineextension On workboards, link ancestor project breadcrumbs to their workboards 2019-03-27 14:42:57 -07:00
events On workboards, link ancestor project breadcrumbs to their workboards 2019-03-27 14:42:57 -07:00
exception Hard code a "close task" action on every column Trigger 2019-03-25 13:21:55 -07:00
herald Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
icon When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip 2019-03-25 14:02:10 -07:00
interface Roughly implement milestone columns on workboards 2016-02-03 16:37:59 -08:00
lipsum Migrate Project status to modular transactions 2017-05-18 11:36:13 -07:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
menuitem Make the "Install Dashboard" flow smoother 2019-04-09 13:34:09 -07:00
order Don't show workboard action previews if the action won't have any effect 2019-03-25 13:24:01 -07:00
phid On workboards, link ancestor project breadcrumbs to their workboards 2019-03-27 14:42:57 -07:00
policyrule Add a "members of all projects" (vs "...any project") custom policy rule to the upstream 2018-06-12 11:51:51 -07:00
query Track how many columns use a particular trigger 2019-03-25 14:04:55 -07:00
remarkup Fix spelling 2017-10-09 10:48:04 -07:00
search Support Ferret engine in Projects 2017-09-07 13:24:23 -07:00
searchfield Fix a bad call when prefilling ApplicationSearch from ?projects=some_slug 2016-02-08 10:44:33 -08:00
storage Distinguish between "bad record format" and "bad record value" when validating Trigger rules 2019-04-17 12:40:55 -07:00
trigger Distinguish between "bad record format" and "bad record value" when validating Trigger rules 2019-04-17 12:40:55 -07:00
typeahead Support subtypes in Projects 2019-01-30 06:17:55 -08:00
view Fix task hovercards showing a "Not Editable" state 2019-03-26 15:56:09 -07:00
xaction Distinguish between "bad record format" and "bad record value" when validating Trigger rules 2019-04-17 12:40:55 -07:00