mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-27 07:50:57 +01:00
87207b2f4e
Summary:
- Move email to a separate table.
- Migrate existing email to new storage.
- Allow users to add and remove email addresses.
- Allow users to verify email addresses.
- Allow users to change their primary email address.
- Convert all the registration/reset/login code to understand these changes.
- There are a few security considerations here but I think I've addressed them. Principally, it is important to never let a user acquire a verified email address they don't actually own. We ensure this by tightening the scoping of token generation rules to be (user, email) specific.
- This should have essentially zero impact on Facebook, but may require some minor changes in the registration code -- I don't exactly remember how it is set up.
Not included here (next steps):
- Allow configuration to restrict email to certain domains.
- Allow configuration to require validated email.
Test Plan:
This is a fairly extensive, difficult-to-test change.
- From "Email Addresses" interface:
- Added new email (verified email verifications sent).
- Changed primary email (verified old/new notificactions sent).
- Resent verification emails (verified they sent).
- Removed email.
- Tried to add already-owned email.
- Created new users with "accountadmin". Edited existing users with "accountadmin".
- Created new users with "add_user.php".
- Created new users with web interface.
- Clicked welcome email link, verified it verified email.
- Reset password.
- Linked/unlinked oauth accounts.
- Logged in with oauth account.
- Logged in with email.
- Registered with Oauth account.
- Tried to register with OAuth account with duplicate email.
- Verified errors for email verification with bad tokens, etc.
Reviewers: btrahan, vrana, jungejason
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T1184
Differential Revision: https://secure.phabricator.com/D2393
49 lines
1.4 KiB
PHP
49 lines
1.4 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
echo "Migrating user emails...\n";
|
|
|
|
$table = new PhabricatorUser();
|
|
$conn = $table->establishConnection('r');
|
|
|
|
$emails = queryfx_all(
|
|
$conn,
|
|
'SELECT phid, email FROM %T',
|
|
$table->getTableName());
|
|
$emails = ipull($emails, 'email', 'phid');
|
|
|
|
$etable = new PhabricatorUserEmail();
|
|
$econn = $etable->establishConnection('w');
|
|
|
|
foreach ($emails as $phid => $email) {
|
|
|
|
// NOTE: Grandfather all existing email in as primary / verified. We generate
|
|
// verification codes because they are used for password resets, etc.
|
|
|
|
echo "Migrating '{$phid}'...\n";
|
|
queryfx(
|
|
$econn,
|
|
'INSERT INTO %T (userPHID, address, verificationCode, isVerified, isPrimary)
|
|
VALUES (%s, %s, %s, 1, 1)',
|
|
$etable->getTableName(),
|
|
$phid,
|
|
$email,
|
|
PhabricatorFile::readRandomCharacters(24));
|
|
}
|
|
|
|
echo "Done.\n";
|