1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
phorge-phorge/src/applications/calendar
epriestley 872bcd4487 Make limits and ranges work better with Calendar event queries
Summary:
Fixes T8911. This corrects several issues which could crop up if a calendar event query matched more results than the query limit:

  - The desired order was not applied by the SearchEngine -- it applies the first builtin order instead. Provide a proper builtin order.
  - When we generate ghosts, we can't do limiting in the database because we may select and then immediately discard a large number of parent events which are outside of the query range.
    - For now, just don't limit results to get the behavior correct.
    - This may need to be refined eventually to improve performance.
  - When trimming events, we could trim parents and fail to generate ghosts from them. Separate parent events out first.
  - Try to simplify some logic.

Test Plan: An "Upcoming" dashboard panel with limit 10 and the main Calendar "Upcoming Events" UI now show the same results.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8911

Differential Revision: https://secure.phabricator.com/D16289
2016-07-13 15:39:00 -07:00
..
__tests__ Make translation, timezone and pronoun into real settings 2016-06-02 06:29:47 -07:00
application Switch Calendar to EditEngine 2016-07-13 07:45:02 -07:00
command Convert Calendar to Modular Transactions 2016-07-13 07:46:33 -07:00
conduit Add calendar.event.search and calendar.event.edit 2016-07-13 10:17:46 -07:00
controller Add calendar.event.search and calendar.event.edit 2016-07-13 10:17:46 -07:00
editor Add calendar.event.search and calendar.event.edit 2016-07-13 10:17:46 -07:00
icon Provide a "PHUIFormIconSetControl" 2015-12-16 08:46:51 -08:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Make limits and ranges work better with Calendar event queries 2016-07-13 15:39:00 -07:00
remarkup Calendar event monograms, part 3. Remarkup for calendar event monograms. 2015-04-27 14:27:34 -07:00
search Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
storage Add calendar.event.search and calendar.event.edit 2016-07-13 10:17:46 -07:00
util Linter fixes 2015-12-03 07:44:23 +11:00
view Clicking in day view should create new event 2015-05-24 11:22:33 -07:00
xaction Convert Calendar to Modular Transactions 2016-07-13 07:46:33 -07:00