mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-21 09:48:47 +02:00
87fa97e49a
Summary: Single brackets are getting some troublesome false positives in Facebook's install. Particularly, there's a weird convention at Facebook of tagging diffs by putting stuff like "[perf]" or "[chat]" in the title, although this isn't turned into structured data at any stage. When commits appear in Diffusion, we currently link such ad-hoc tags to Phriction. Wikipedia uses double-bracket sytnax, as do many other wikis, so this seems like a reasonable burden to place on the lightweightness of the markup. The alternative is selectively disabling Phriction markup in some interfaces, but I'd rather allow integration in commit messages and just guard the syntax more closely. (I'm not providing any sort of migration plan since this landed less than a week ago and I'm pretty confident no one has built a huge wiki yet, but I added a CHANGELOG note.) Test Plan: Edited a wiki document and added some links. Verified single brackets were unlinked and double brackets were linked. Reviewed By: jungejason Reviewers: hsb, aran, jungejason, tuomaspelkonen CC: aran, jungejason, epriestley Differential Revision: 689 |
||
|---|---|---|
| .. | ||
| celerity | ||
| daemon | ||
| diff/engine | ||
| env | ||
| javelin | ||
| lint | ||
| markup/remarkup/markuprule | ||
| setup | ||
| testing/testcase | ||