mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 18:32:41 +01:00
9838251515
Summary: Fixes T2691. Now, all PhabricatorActionListViews in the codebase setObjectHref to $request->getRequestURI. This value is passed over to PhabricatorActionItems right before they are rendered. If a PhabricatorActionItem is a workflow and there is no user OR the user is logged out, we used this objectURI to construct a log in URI. Potentially added some undesirable behavior to aggressively setUser (and later setObjectURI) from within the List on Actions... This should be okay-ish unless there was a vision of actions having different user objects associated with them. I think this is a safe assumption. Test Plan: played around with a mock all logged out (Ref T2652) and it worked! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2691 Differential Revision: https://secure.phabricator.com/D6416
259 lines
6.7 KiB
PHP
259 lines
6.7 KiB
PHP
<?php
|
|
|
|
final class PhabricatorWorkerTaskDetailController
|
|
extends PhabricatorDaemonController {
|
|
|
|
private $id;
|
|
|
|
public function willProcessRequest(array $data) {
|
|
$this->id = $data['id'];
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$task = id(new PhabricatorWorkerActiveTask())->load($this->id);
|
|
if (!$task) {
|
|
$task = id(new PhabricatorWorkerArchiveTask())->load($this->id);
|
|
}
|
|
|
|
if (!$task) {
|
|
$title = pht('Task Does Not Exist');
|
|
|
|
$error_view = new AphrontErrorView();
|
|
$error_view->setTitle(pht('No Such Task'));
|
|
$error_view->appendChild(phutil_tag(
|
|
'p',
|
|
array(),
|
|
pht('This task may have recently been garbage collected.')));
|
|
$error_view->setSeverity(AphrontErrorView::SEVERITY_NODATA);
|
|
|
|
$content = $error_view;
|
|
} else {
|
|
$title = pht('Task %d', $task->getID());
|
|
|
|
$header = id(new PhabricatorHeaderView())
|
|
->setHeader(pht('Task %d (%s)',
|
|
$task->getID(),
|
|
$task->getTaskClass()));
|
|
|
|
$actions = $this->buildActionListView($task);
|
|
$properties = $this->buildPropertyListView($task);
|
|
|
|
$retry_head = id(new PhabricatorHeaderView())
|
|
->setHeader(pht('Retries'));
|
|
|
|
$retry_info = $this->buildRetryListView($task);
|
|
|
|
$content = array(
|
|
$header,
|
|
$actions,
|
|
$properties,
|
|
$retry_head,
|
|
$retry_info,
|
|
);
|
|
}
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addCrumb(
|
|
id(new PhabricatorCrumbView())
|
|
->setName($title));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$crumbs,
|
|
$content,
|
|
),
|
|
array(
|
|
'title' => $title,
|
|
'dust' => true,
|
|
'device' => true,
|
|
));
|
|
}
|
|
|
|
private function buildActionListView(PhabricatorWorkerTask $task) {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
$id = $task->getID();
|
|
|
|
$view = id(new PhabricatorActionListView())
|
|
->setUser($user)
|
|
->setObjectURI($request->getRequestURI());
|
|
|
|
if ($task->isArchived()) {
|
|
$result_success = PhabricatorWorkerArchiveTask::RESULT_SUCCESS;
|
|
$can_retry = ($task->getResult() != $result_success);
|
|
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('Retry Task'))
|
|
->setHref($this->getApplicationURI('/task/'.$id.'/retry/'))
|
|
->setIcon('undo')
|
|
->setWorkflow(true)
|
|
->setDisabled(!$can_retry));
|
|
} else {
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('Cancel Task'))
|
|
->setHref($this->getApplicationURI('/task/'.$id.'/cancel/'))
|
|
->setIcon('delete')
|
|
->setWorkflow(true));
|
|
}
|
|
|
|
$can_release = (!$task->isArchived()) &&
|
|
($task->getLeaseOwner());
|
|
|
|
$view->addAction(
|
|
id(new PhabricatorActionView())
|
|
->setName(pht('Free Lease'))
|
|
->setHref($this->getApplicationURI('/task/'.$id.'/release/'))
|
|
->setIcon('unlock')
|
|
->setWorkflow(true)
|
|
->setDisabled(!$can_release));
|
|
|
|
return $view;
|
|
}
|
|
|
|
private function buildPropertyListView(PhabricatorWorkerTask $task) {
|
|
$view = new PhabricatorPropertyListView();
|
|
|
|
if ($task->isArchived()) {
|
|
switch ($task->getResult()) {
|
|
case PhabricatorWorkerArchiveTask::RESULT_SUCCESS:
|
|
$status = pht('Complete');
|
|
break;
|
|
case PhabricatorWorkerArchiveTask::RESULT_FAILURE:
|
|
$status = pht('Failed');
|
|
break;
|
|
case PhabricatorWorkerArchiveTask::RESULT_CANCELLED:
|
|
$status = pht('Cancelled');
|
|
break;
|
|
default:
|
|
throw new Exception("Unknown task status!");
|
|
}
|
|
} else {
|
|
$status = pht('Queued');
|
|
}
|
|
|
|
$view->addProperty(
|
|
pht('Task Status'),
|
|
$status);
|
|
|
|
$view->addProperty(
|
|
pht('Task Class'),
|
|
$task->getTaskClass());
|
|
|
|
if ($task->getLeaseExpires()) {
|
|
if ($task->getLeaseExpires() > time()) {
|
|
$lease_status = pht('Leased');
|
|
} else {
|
|
$lease_status = pht('Lease Expired');
|
|
}
|
|
} else {
|
|
$lease_status = phutil_tag('em', array(), pht('Not Leased'));
|
|
}
|
|
|
|
$view->addProperty(
|
|
pht('Lease Status'),
|
|
$lease_status);
|
|
|
|
$view->addProperty(
|
|
pht('Lease Owner'),
|
|
$task->getLeaseOwner()
|
|
? $task->getLeaseOwner()
|
|
: phutil_tag('em', array(), pht('None')));
|
|
|
|
if ($task->getLeaseExpires() && $task->getLeaseOwner()) {
|
|
$expires = ($task->getLeaseExpires() - time());
|
|
$expires = phabricator_format_relative_time_detailed($expires);
|
|
} else {
|
|
$expires = phutil_tag('em', array(), pht('None'));
|
|
}
|
|
|
|
$view->addProperty(
|
|
pht('Lease Expires'),
|
|
$expires);
|
|
|
|
if ($task->isArchived()) {
|
|
$duration = number_format($task->getDuration()).' us';
|
|
} else {
|
|
$duration = phutil_tag('em', array(), pht('Not Completed'));
|
|
}
|
|
|
|
$view->addProperty(
|
|
pht('Duration'),
|
|
$duration);
|
|
|
|
$data = id(new PhabricatorWorkerTaskData())->load($task->getDataID());
|
|
$task->setData($data->getData());
|
|
$worker = $task->getWorkerInstance();
|
|
$data = $worker->renderForDisplay();
|
|
|
|
$view->addProperty(
|
|
pht('Data'),
|
|
$data);
|
|
|
|
return $view;
|
|
}
|
|
|
|
private function buildRetryListView(PhabricatorWorkerTask $task) {
|
|
$view = new PhabricatorPropertyListView();
|
|
|
|
$data = id(new PhabricatorWorkerTaskData())->load($task->getDataID());
|
|
$task->setData($data->getData());
|
|
$worker = $task->getWorkerInstance();
|
|
|
|
$view->addProperty(
|
|
pht('Failure Count'),
|
|
$task->getFailureCount());
|
|
|
|
$retry_count = $worker->getMaximumRetryCount();
|
|
if ($retry_count === null) {
|
|
$max_retries = phutil_tag('em', array(), pht('Retries Forever'));
|
|
$retry_count = INF;
|
|
} else {
|
|
$max_retries = $retry_count;
|
|
}
|
|
|
|
$view->addProperty(
|
|
pht('Maximum Retries'),
|
|
$max_retries);
|
|
|
|
$projection = clone $task;
|
|
$projection->makeEphemeral();
|
|
|
|
$next = array();
|
|
for ($ii = $task->getFailureCount(); $ii < $retry_count; $ii++) {
|
|
$projection->setFailureCount($ii);
|
|
$next[] = $worker->getWaitBeforeRetry($projection);
|
|
if (count($next) > 10) {
|
|
break;
|
|
}
|
|
}
|
|
|
|
if ($next) {
|
|
$cumulative = 0;
|
|
foreach ($next as $key => $duration) {
|
|
if ($duration === null) {
|
|
$duration = 60;
|
|
}
|
|
$cumulative += $duration;
|
|
$next[$key] = phabricator_format_relative_time($cumulative);
|
|
}
|
|
if ($ii != $retry_count) {
|
|
$next[] = '...';
|
|
}
|
|
$retries_in = implode(', ', $next);
|
|
} else {
|
|
$retries_in = pht('No More Retries');
|
|
}
|
|
|
|
$view->addProperty(
|
|
pht('Retries After'),
|
|
$retries_in);
|
|
|
|
return $view;
|
|
}
|
|
|
|
}
|