mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 16:22:43 +01:00
8860f4724f
Summary: Ref T8089. We have a lot of broken/confusing/prototype build steps that I want to hide from users when we unprototype Harbormaster. The dialog is also just kind of unwieldy. Organize this UI a little better and put all the sketchy junk in a "prototypes" group that you can't see unless prototypes are enabled. This doesn't break anything (the old steps will still work fine), but should reduce user confusion. Test Plan: Old UI: {F691439} New UI (prototypes off): {F691440} New UI (prototypes on): {F691441} Reviewers: chad Reviewed By: chad Maniphest Tasks: T8089 Differential Revision: https://secure.phabricator.com/D13803
113 lines
2.8 KiB
PHP
113 lines
2.8 KiB
PHP
<?php
|
|
|
|
final class HarbormasterHTTPRequestBuildStepImplementation
|
|
extends HarbormasterBuildStepImplementation {
|
|
|
|
public function getName() {
|
|
return pht('Make HTTP Request');
|
|
}
|
|
|
|
public function getGenericDescription() {
|
|
return pht('Make an HTTP request.');
|
|
}
|
|
|
|
public function getBuildStepGroupKey() {
|
|
return HarbormasterExternalBuildStepGroup::GROUPKEY;
|
|
}
|
|
|
|
public function getDescription() {
|
|
$domain = null;
|
|
$uri = $this->getSetting('uri');
|
|
if ($uri) {
|
|
$domain = id(new PhutilURI($uri))->getDomain();
|
|
}
|
|
|
|
$method = $this->formatSettingForDescription('method', 'POST');
|
|
$domain = $this->formatValueForDescription($domain);
|
|
|
|
if ($this->getSetting('credential')) {
|
|
return pht(
|
|
'Make an authenticated HTTP %s request to %s.',
|
|
$method,
|
|
$domain);
|
|
} else {
|
|
return pht(
|
|
'Make an HTTP %s request to %s.',
|
|
$method,
|
|
$domain);
|
|
}
|
|
}
|
|
|
|
public function execute(
|
|
HarbormasterBuild $build,
|
|
HarbormasterBuildTarget $build_target) {
|
|
|
|
$viewer = PhabricatorUser::getOmnipotentUser();
|
|
$settings = $this->getSettings();
|
|
$variables = $build_target->getVariables();
|
|
|
|
$uri = $this->mergeVariables(
|
|
'vurisprintf',
|
|
$settings['uri'],
|
|
$variables);
|
|
|
|
$log_body = $build->createLog($build_target, $uri, 'http-body');
|
|
$start = $log_body->start();
|
|
|
|
$method = nonempty(idx($settings, 'method'), 'POST');
|
|
|
|
$future = id(new HTTPSFuture($uri))
|
|
->setMethod($method)
|
|
->setTimeout(60);
|
|
|
|
$credential_phid = $this->getSetting('credential');
|
|
if ($credential_phid) {
|
|
$key = PassphrasePasswordKey::loadFromPHID(
|
|
$credential_phid,
|
|
$viewer);
|
|
$future->setHTTPBasicAuthCredentials(
|
|
$key->getUsernameEnvelope()->openEnvelope(),
|
|
$key->getPasswordEnvelope());
|
|
}
|
|
|
|
list($status, $body, $headers) = $this->resolveFuture(
|
|
$build,
|
|
$build_target,
|
|
$future);
|
|
|
|
$log_body->append($body);
|
|
$log_body->finalize($start);
|
|
|
|
if ($status->getStatusCode() != 200) {
|
|
$build->setBuildStatus(HarbormasterBuild::STATUS_FAILED);
|
|
}
|
|
}
|
|
|
|
public function getFieldSpecifications() {
|
|
return array(
|
|
'uri' => array(
|
|
'name' => pht('URI'),
|
|
'type' => 'text',
|
|
'required' => true,
|
|
),
|
|
'method' => array(
|
|
'name' => pht('HTTP Method'),
|
|
'type' => 'select',
|
|
'options' => array_fuse(array('POST', 'GET', 'PUT', 'DELETE')),
|
|
),
|
|
'credential' => array(
|
|
'name' => pht('Credentials'),
|
|
'type' => 'credential',
|
|
'credential.type'
|
|
=> PassphrasePasswordCredentialType::CREDENTIAL_TYPE,
|
|
'credential.provides'
|
|
=> PassphrasePasswordCredentialType::PROVIDES_TYPE,
|
|
),
|
|
);
|
|
}
|
|
|
|
public function supportsWaitForMessage() {
|
|
return true;
|
|
}
|
|
|
|
}
|