1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 10:52:41 +01:00
phorge-phorge/webroot/rsrc/js/application/differential
epriestley e9f4a84a89 Allow inline comments to be individually hidden
Summary:
Ref T7447. Implements per-viewer comment hiding. Once a comment is obsolete or uninteresting, you can hide it completely.

This is sticky per-user.

My hope is that this will strike a better balance between concerns than some of the other approaches (conservative porting, summarization, hide-all).

Specifically, this adds a new action here:

{F435621}

Clicking it completely collapses the comment into a small icon on the previous line, and saves the comment state as hidden for you:

{F435626}

You can click the icon to reveal all hidden comments below the line.

Test Plan:
  - Hid comments.
  - Showed comments.
  - Created, edited, deleted and submitted comments.
  - Used Diffusion comments (hiding is not implemented there yet, but I'd plan to bring it there eventually if it works out in Differential).

Reviewers: btrahan, chad

Reviewed By: btrahan

Subscribers: jparise, yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D13009
2015-05-27 10:28:38 -07:00
..
behavior-add-reviewers-and-ccs.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-comment-jump.js Various minor JSHint fixes. 2014-07-01 06:00:12 +10:00
behavior-comment-preview.js Maniphest + Differential - don't show transaction preview until user interacts with the form. 2015-05-20 13:54:22 -07:00
behavior-diff-radios.js Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
behavior-dropdown-menus.js Make "Show Context" persist rendering, whitespace, encoding, etc 2015-03-05 14:03:00 -08:00
behavior-edit-inline-comments.js Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
behavior-keyboard-nav.js diffusion / differential - better handle case where no comment selected 2014-11-12 12:26:22 -08:00
behavior-populate.js Merge behavior-show-more into behavior-populate 2015-03-05 14:03:15 -08:00
behavior-show-field-details.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-toggle-files.js Better JS for Differential File Collapsing Undo 2013-08-13 16:14:26 -07:00
behavior-user-select.js Enable selecting text in Differential shield and gap 2012-09-20 15:20:47 -07:00
ChangesetViewManager.js Don't highlight very large files by default 2015-03-24 05:26:39 -07:00
DifferentialInlineCommentEditor.js Fix "reply" to left-side inline appearing on right side 2015-05-07 11:09:29 -07:00