phorge-phorge/resources/sql/autopatches/20150410.nukeruleedit.sql at 894d0dc51bc3dcb3998d2c86eb62e83d3e4c741e - revi-archive/phorge-phorge - SiliconForest Atelier

revi-archive/phorge-phorge

mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00

epriestley 15b41f5639 Remove Herald rule edit log

Summary:
Fixes T7601. Ref T7803, weakly (this removes a Query subclass with ad-hoc paging). Herald has a very old edit log which predates transactions and is essentially useless and not really policy-aware. I think it's doing more harm than good; remove it.

Herald rules have proper transactions, but rule edits don't currently render something nice into the transaction log. This is definitely the way forward, but we haven't seen requests for this so don't bother building it for now.

I did put a nice end-cap on the transaction log, though.

Test Plan:
  - Viewed Herald UI.
  - Grepped for removed classes and methods.
  - Edited a rule.
  - Viewed rule transaction log.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: cburroughs, chad, epriestley

Maniphest Tasks: T7601, T7803

Differential Revision: https://secure.phabricator.com/D12346

2015-04-11 08:50:50 -07:00

1 line

48 B

SQL

Raw Blame History

DROP TABLE {$NAMESPACE}_herald.herald_ruleedit;