mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-20 09:18:48 +02:00
b560014577
Summary:
Rebuilds the UI in Differential commenting. Specifically we look at the following design patterns:
**To the author:**
- The author of the diff should be able to easily identify what comments are done and not done.
- We keep undone comments yellow
- Clicking done turns comment block into 'unsubmitted state'
**To the reviewer:**
- Easier understanding of unsubmitted states
- All conversations to be yellow/important
**Todo**
- Not all color CSS states correct
- Unpulished checkbox support
Test Plan:
Test leaving comments, published and unpublished. Checking Done, unpublished and published. Check delete states.
From the Diff Author's perspective:
{F352094}
For a Diff commenter's perspective:
{F352095}
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T1460, T7660, T7503
Differential Revision: https://secure.phabricator.com/D12171
|
||
|---|---|---|
| .. | ||
| calendar | ||
| phui-action-header-view.css | ||
| phui-action-list.css | ||
| phui-action-panel.css | ||
| phui-box.css | ||
| phui-button.css | ||
| phui-crumbs-view.css | ||
| phui-document.css | ||
| phui-feed-story.css | ||
| phui-fontkit.css | ||
| phui-form-view.css | ||
| phui-form.css | ||
| phui-header-view.css | ||
| phui-icon.css | ||
| phui-image-mask.css | ||
| phui-info-panel.css | ||
| phui-info-view.css | ||
| phui-list.css | ||
| phui-object-box.css | ||
| phui-object-item-list-view.css | ||
| phui-pinboard-view.css | ||
| phui-property-list-view.css | ||
| phui-remarkup-preview.css | ||
| phui-spacing.css | ||
| phui-status.css | ||
| phui-tag-view.css | ||
| phui-text.css | ||
| phui-timeline-view.css | ||
| phui-workboard-view.css | ||
| phui-workpanel-view.css | ||