1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-04 12:42:43 +01:00
phorge-phorge/src/applications/auth/factor
epriestley 8a4bf38655 Use 160-bit TOTP keys rather than 80-bit TOTP keys
Summary:
See <https://hackerone.com/reports/435648>. We currently use 80-bit TOTP keys. The RFC suggests 128 as a minimum and recommends 160.

The math suggests that doing the hashing for an 80-bit key is hard (slightly beyond the reach of a highly motivated state actor, today) but there's no reason not to use 160 bits instead to put this completely out of reach.

See some additional discussion on the HackerOne report about enormous key sizes, number of required observations, etc.

Test Plan: Added a new 160-bit TOTP factor to Google Authenticator without issue.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19792
2018-11-07 15:44:02 -08:00
..
__tests__ Fix spelling 2017-10-09 10:48:04 -07:00
PhabricatorAuthFactor.php Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
PhabricatorAuthTOTPKeyTemporaryTokenType.php Formally modularize MFA/TOTP tokens, provide a module panel for temporary tokens 2016-03-16 09:33:58 -07:00
PhabricatorTOTPAuthFactor.php Use 160-bit TOTP keys rather than 80-bit TOTP keys 2018-11-07 15:44:02 -08:00