mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 11:22:40 +01:00
fe646ec328
Summary: Ref PHI91. When Owners (or Herald, or manual user action) adds package reviewers to a revision, later updates to the revision make some of them less relevant or irrelevant. Provide a hint when a package reviewer doesn't own any of the paths that a diff changes. Humans can then decide if the reviewer is obsolete/irrelevant or not. This is a rough cut to get the feature working, design could probably use some tweaking if it sticks. Test Plan: {F5204309} Reviewers: amckinley Reviewed By: amckinley Subscribers: jboning Differential Revision: https://secure.phabricator.com/D18663
216 lines
6.2 KiB
PHP
216 lines
6.2 KiB
PHP
<?php
|
|
|
|
final class DifferentialDiffViewController extends DifferentialController {
|
|
|
|
public function shouldAllowPublic() {
|
|
return true;
|
|
}
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$viewer = $this->getViewer();
|
|
$id = $request->getURIData('id');
|
|
|
|
$diff = id(new DifferentialDiffQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($id))
|
|
->executeOne();
|
|
if (!$diff) {
|
|
return new Aphront404Response();
|
|
}
|
|
|
|
if ($diff->getRevisionID()) {
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI('/D'.$diff->getRevisionID().'?id='.$diff->getID());
|
|
}
|
|
|
|
if ($request->isFormPost()) {
|
|
$diff_id = $diff->getID();
|
|
$revision_id = $request->getInt('revisionID');
|
|
if ($revision_id) {
|
|
$attach_uri = "/revision/attach/{$diff_id}/to/{$revision_id}/";
|
|
} else {
|
|
$attach_uri = "/revision/attach/{$diff_id}/to/";
|
|
}
|
|
$attach_uri = $this->getApplicationURI($attach_uri);
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI($attach_uri);
|
|
}
|
|
|
|
$diff_phid = $diff->getPHID();
|
|
$buildables = id(new HarbormasterBuildableQuery())
|
|
->setViewer($viewer)
|
|
->withBuildablePHIDs(array($diff_phid))
|
|
->withManualBuildables(false)
|
|
->needBuilds(true)
|
|
->needTargets(true)
|
|
->execute();
|
|
$buildables = mpull($buildables, null, 'getBuildablePHID');
|
|
$diff->attachBuildable(idx($buildables, $diff_phid));
|
|
|
|
// TODO: implement optgroup support in AphrontFormSelectControl?
|
|
$select = array();
|
|
$select[] = hsprintf('<optgroup label="%s">', pht('Create New Revision'));
|
|
$select[] = phutil_tag(
|
|
'option',
|
|
array('value' => ''),
|
|
pht('Create a new Revision...'));
|
|
$select[] = hsprintf('</optgroup>');
|
|
|
|
$selected_id = $request->getInt('revisionID');
|
|
|
|
$revisions = $this->loadSelectableRevisions($viewer, $selected_id);
|
|
|
|
if ($revisions) {
|
|
$select[] = hsprintf(
|
|
'<optgroup label="%s">',
|
|
pht('Update Existing Revision'));
|
|
foreach ($revisions as $revision) {
|
|
if ($selected_id == $revision->getID()) {
|
|
$selected = 'selected';
|
|
} else {
|
|
$selected = null;
|
|
}
|
|
|
|
$select[] = phutil_tag(
|
|
'option',
|
|
array(
|
|
'value' => $revision->getID(),
|
|
'selected' => $selected,
|
|
),
|
|
id(new PhutilUTF8StringTruncator())
|
|
->setMaximumGlyphs(128)
|
|
->truncateString(
|
|
'D'.$revision->getID().' '.$revision->getTitle()));
|
|
}
|
|
$select[] = hsprintf('</optgroup>');
|
|
}
|
|
|
|
$select = phutil_tag(
|
|
'select',
|
|
array('name' => 'revisionID'),
|
|
$select);
|
|
|
|
$form = id(new AphrontFormView())
|
|
->setViewer($viewer)
|
|
->appendRemarkupInstructions(
|
|
pht(
|
|
'Review the diff for correctness. When you are satisfied, either '.
|
|
'**create a new revision** or **update an existing revision**.'))
|
|
->appendChild(
|
|
id(new AphrontFormMarkupControl())
|
|
->setLabel(pht('Attach To'))
|
|
->setValue($select))
|
|
->appendChild(
|
|
id(new AphrontFormSubmitControl())
|
|
->setValue(pht('Continue')));
|
|
|
|
$props = id(new DifferentialDiffProperty())->loadAllWhere(
|
|
'diffID = %d',
|
|
$diff->getID());
|
|
$props = mpull($props, 'getData', 'getName');
|
|
|
|
$property_head = id(new PHUIHeaderView())
|
|
->setHeader(pht('Properties'));
|
|
|
|
$property_view = new PHUIPropertyListView();
|
|
|
|
$changesets = $diff->loadChangesets();
|
|
$changesets = msort($changesets, 'getSortKey');
|
|
|
|
$this->buildPackageMaps($changesets);
|
|
|
|
$table_of_contents = $this->buildTableOfContents(
|
|
$changesets,
|
|
$changesets,
|
|
$diff->loadCoverageMap($viewer));
|
|
|
|
$refs = array();
|
|
foreach ($changesets as $changeset) {
|
|
$refs[$changeset->getID()] = $changeset->getID();
|
|
}
|
|
|
|
$details = id(new DifferentialChangesetListView())
|
|
->setChangesets($changesets)
|
|
->setVisibleChangesets($changesets)
|
|
->setRenderingReferences($refs)
|
|
->setStandaloneURI('/differential/changeset/')
|
|
->setDiff($diff)
|
|
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
|
->setTitle(pht('Diff %d', $diff->getID()))
|
|
->setUser($request->getUser());
|
|
|
|
$title = pht('Diff %d', $diff->getID());
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
$crumbs->addTextCrumb($title);
|
|
$crumbs->setBorder(true);
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
->setHeader($title);
|
|
|
|
$prop_box = id(new PHUIObjectBoxView())
|
|
->setHeader($property_head)
|
|
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
|
|
->addPropertyList($property_view)
|
|
->setForm($form);
|
|
|
|
$view = id(new PHUITwoColumnView())
|
|
->setHeader($header)
|
|
->setMainColumn(array(
|
|
|
|
))
|
|
->setFooter(array(
|
|
$prop_box,
|
|
$table_of_contents,
|
|
$details,
|
|
));
|
|
|
|
$page = $this->newPage()
|
|
->setTitle(pht('Diff View'))
|
|
->setCrumbs($crumbs)
|
|
->appendChild($view);
|
|
return $page;
|
|
}
|
|
|
|
private function loadSelectableRevisions(
|
|
PhabricatorUser $viewer,
|
|
$selected_id) {
|
|
|
|
$revisions = id(new DifferentialRevisionQuery())
|
|
->setViewer($viewer)
|
|
->withAuthors(array($viewer->getPHID()))
|
|
->withIsOpen(true)
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->execute();
|
|
$revisions = mpull($revisions, null, 'getID');
|
|
|
|
// If a specific revision is selected (for example, because the user is
|
|
// following the "Update Diff" workflow), but not present in the dropdown,
|
|
// try to add it to the dropdown even if it is closed. This allows the
|
|
// workflow to be used to update abandoned revisions.
|
|
|
|
if ($selected_id) {
|
|
if (empty($revisions[$selected_id])) {
|
|
$selected = id(new DifferentialRevisionQuery())
|
|
->setViewer($viewer)
|
|
->withAuthors(array($viewer->getPHID()))
|
|
->withIDs(array($selected_id))
|
|
->requireCapabilities(
|
|
array(
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
))
|
|
->execute();
|
|
$revisions = mpull($selected, null, 'getID') + $revisions;
|
|
}
|
|
}
|
|
|
|
return $revisions;
|
|
}
|
|
|
|
|
|
}
|