1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/herald
epriestley 592591e715 Clean up various pieces of dead/obsolete Differential code
Summary:
Ref T2222.

  - Removes `DifferentialTasksAttacher`, which has had no callsites for a very long time.
  - Moves `differential.getrevisioncomments` off `DifferentialCommentQuery`.
  - Moves Releeph churn field off `DifferentialCommentQuery`.
  - Removes dead code in `DifferentialRevisionViewController`.
  - Removes `DifferentialException` (no references).
  - Removes `DifferentialRevision->loadComments()` (no callsites).
  - Removes `DifferentialRevision->loadReviewedBy()` (all callsites updated).
  - Removes `DifferentialCommentQuery` (all callsites updated).

Test Plan: Mostly a lot of `grep`.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8476
2014-03-11 13:02:19 -07:00
..
adapter Clean up various pieces of dead/obsolete Differential code 2014-03-11 13:02:19 -07:00
application Herald - add application search for transcripts 2014-02-21 12:51:25 -08:00
capability Remove the "create rules" Herald capability 2013-10-09 13:55:44 -07:00
config Lay most groundwork for Herald object rules 2013-12-27 13:17:10 -08:00
controller Herald - add application search for transcripts 2014-02-21 12:51:25 -08:00
editor Allow Herald rules to be disabled, instead of deleted 2013-10-06 17:10:29 -07:00
engine Various linter fixes. 2014-02-26 12:44:58 -08:00
garbagecollector Modularize the Garbage Collector 2014-01-15 10:02:24 -08:00
phid Give Herald rules a standard "Hnnn" object name 2013-12-18 12:00:18 -08:00
query Herald - add application search for transcripts 2014-02-21 12:51:25 -08:00
remarkup Give Herald rules a standard "Hnnn" object name 2013-12-18 12:00:18 -08:00
storage Various linter fixes. 2014-02-26 12:44:58 -08:00
view Move PhabricatorObjectItem to PHUIObjectItem, add 'plain' setting for lists. 2013-09-09 14:14:34 -07:00