1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-22 18:28:47 +02:00
phorge-phorge/src/applications/config
epriestley 943c62d1e9 Add missing expected keys and uniqueness
Summary:
Ref T1191.

  - Adds definitions for missing keys and keys with wrong uniqueness. Generally, I defined these before fixing the key query to actually pull all keys and support uniqueness.
  - Moves "key uniqueness" to note severity; this is fixable (probably?) and there are no remaining issues.
  - Moves "Missing Key" to note severity; missing keys are fixable and all remaining missing keys are really missing (either missing edge keys, or missing PHID keys):

{F210089}

  - Moves "Surplus Key" to note seveirty; surplus keys are fixable all remaining surplus keys are really surplus (duplicate key in Harbormaster, key on unused column in Worker):

{F210090}

Test Plan:
  - Vetted missing/surplus/unique messages.
  - 146 issues remaining.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10590
2014-10-01 07:53:50 -07:00
..
application Load all keys, support unique keys, and provide an "all issues" view 2014-09-19 11:46:30 -07:00
check Add a setup issue to detect systems vulnerable to "Shellshock" 2014-09-25 11:21:11 -07:00
controller Add missing expected keys and uniqueness 2014-10-01 07:53:50 -07:00
custom Update callsites of phutil_json_decode. 2014-06-21 00:39:37 +10:00
editor Modularize mail tags 2014-08-12 12:28:41 -07:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
issue Add a configuration warning when memory_limit will limit file uploads 2014-09-04 12:48:34 -07:00
json Mask remaining config values, and implement set type 2013-01-16 15:06:07 -08:00
management Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
option Fix "are are" in explanatory text 2014-09-18 08:21:34 -07:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
response Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
schema Add missing expected keys and uniqueness 2014-10-01 07:53:50 -07:00
storage Add missing expected keys and uniqueness 2014-10-01 07:53:50 -07:00
view Make it easier to ignore setup issues 2014-09-05 12:26:58 -07:00