revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 8c7f114b4d Fix an issue where "Export Data" could fail if a user had a nonempty custom policy preference 
Summary:
The "Export Data" workflow incorrectly uses the "Policy Favorites" setting to choose a default export format. This is just a copy/paste error; the correct setting exists and is unused.

If the setting value is an array (as the "Policy Favorites" value often is), we try to use it as an array index. This generates a runtime exception after D21044.

```
[2020-06-16 06:32:12] EXCEPTION: (RuntimeException) Illegal offset type in isset or empty at [<arcanist>/src/error/PhutilErrorHandler.php:263]
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/search/controller/PhabricatorApplicationSearchController.php:460]
```

  - Use the correct setting.
  - Make sure the value we read is a string.

Test Plan:
  - Used "Export Data" with a nonempty, array-valued "Policy Favorites" setting.
    - Before: runtime exception.
    - After: clean export.
  - Used "Export Data" again, saw my selection from the first time persisted.

Differential Revision: https://secure.phabricator.com/D21361
2020-06-16 06:44:23 -07:00
..
almanac Remove code which overrides "diffusion.ssh-username" when instanced 2020-05-15 07:45:06 -07:00
aphlict Reduce the verbosity of the "Aphlict" log 2020-04-14 13:24:44 -07:00
arcanist/conduit
audit Roughly support inline comment suggestions 2020-05-20 14:26:37 -07:00
auth Fix an issue where passphrase-protected private keys were stored without discarding passphrases 2020-05-13 08:14:37 -07:00
badges Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
base Give the Phortune external portal an order view 2019-08-26 07:49:17 -07:00
cache Straighten out replication/cache behavior in "bin/storage dump" 2019-08-28 08:25:40 -07:00
calendar Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency 2020-02-12 15:17:36 -08:00
celerity Give selected inline comments are more obvious selected state 2020-05-14 14:35:55 -07:00
chatlog Replace "getRequestURI()->setQueryParams(array())" with "getPath()" 2019-02-12 14:43:33 -08:00
conduit Make Conduit "www-form-urlencoded" parsing of "true" and "false" case-insensitive 2020-04-27 13:28:47 -07:00
config Update MySQL schema inspection code for deprecation of integer display widths 2020-05-18 12:10:31 -07:00
conpherence Improve Conpherence behavior for logged out users. 2019-04-02 14:03:08 -07:00
console When a Paste has a useful alternative rendering in Files, provide a hint 2020-05-01 09:09:42 -07:00
countdown Add a test to verify that all routing maps are plausibly valid, and remove some dead routes 2020-02-14 18:06:24 -08:00
daemon Fix missing display cell in daemon summary table 2019-08-12 12:46:48 -07:00
dashboard Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView" 2020-02-04 06:52:23 -08:00
differential Fix an issue where inline comments with only edit suggestions are considered empty 2020-05-23 08:24:57 -07:00
diffusion When executing a repository passthru command via CommandEngine, don't set a timeout 2020-05-22 11:54:36 -07:00
diviner Refine handling of "@task" attributes in Diviner 2020-04-06 11:51:33 -07:00
doorkeeper Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount" 2020-02-22 17:48:46 -08:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView" 2020-02-04 06:52:23 -08:00
fact Return empty data if fact dimension is missing, not yet available 2019-10-30 16:34:22 +02:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Support export of feed transactions to CSV/Excel/etc 2019-05-21 12:47:46 -07:00
files Fix two rendering issues with Jupyter notebooks 2020-05-22 11:53:55 -07:00
flag Add a "Remove flag" action to Herald 2019-09-09 13:15:52 -07:00
fund Update a straggling "getAuthorities()" call in Fund 2019-09-04 07:15:20 -07:00
guides Remove legacy "DashboardInstall" table 2019-04-14 10:27:52 -07:00
harbormaster Add an explicit "uri" to the "harbormaster.buildable.search" results 2020-06-10 17:31:33 -07:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Update Herald rule creation workflow to use more modern UI elements 2020-02-04 07:37:54 -08:00
home Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
legalpad Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Improve timeline rendering for old macros 2019-04-18 18:25:17 -07:00
maniphest Fix an issue where the Maniphest burnup chart was trying to render a non-View object 2020-04-29 05:06:03 -07:00
meta Fix a straggling callsite to "renderApplicationPolicy()" 2019-09-12 16:26:57 -07:00
metamta Remove old code for sending email to external users who create objects via inbound mail 2020-02-20 12:41:51 -08:00
multimeter Fix a PhutilURI issue in Multimeter 2019-02-17 17:39:34 -08:00
notification Hide "notification.servers" configuration and don't follow redirects from Aphlict 2020-04-15 07:00:51 -07:00
nuance Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
oauthserver Lightly modernize OAuth server application view pages 2019-07-02 05:15:37 -07:00
owners When Owners packages are archived, annotate them in tokenizer results 2020-04-17 06:18:04 -07:00
packages Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
passphrase Fix an issue where passphrase-protected private keys were stored without discarding passphrases 2020-05-13 08:14:37 -07:00
paste When creating a File storage object for a Paste, try to give it the same name as the Paste 2020-05-01 09:10:31 -07:00
people Fix an email address validation UI feedback issue when creating new users 2020-05-18 07:35:02 -07:00
phame Add a test to verify that all routing maps are plausibly valid, and remove some dead routes 2020-02-14 18:06:24 -08:00
phid Remove "State Icons" from handles 2019-10-31 12:04:43 -07:00
phlux Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
pholio Fix an out-of-date API call on the destruction pathway for Pholio mocks 2020-04-10 08:01:34 -07:00
phortune In Phortune accounts, prevent self-removal more narrowly 2020-05-26 07:09:42 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Update many Phabricator queries for new %Q query semantics 2018-11-15 03:48:10 -08:00
phrequent Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
phriction Fix an XSS issue with certain high-priority remarkup rules embedded inside lower-priority link rules 2019-12-13 10:37:50 -08:00
phurl Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
policy Remove "stronger/weaker" policy color hints from object headers 2019-11-18 22:05:26 -08:00
ponder Fix a missing pht() in Ponder 2019-04-12 12:18:56 -07:00
project Fix an issue where loading a mangled project graph could fail too abruptly 2020-02-03 08:54:04 -08:00
releeph Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
remarkup Recognize self-URI links to Diffusion files and give them special rendering behavior 2019-05-21 13:07:37 -07:00
repository Survive importing Git commits with no commit message and/or no author 2020-05-18 20:02:21 -07:00
search Fix an issue where "Export Data" could fail if a user had a nonempty custom policy preference 2020-06-16 06:44:23 -07:00
settings Add "idea://" to the upstream editor whitelist 2020-05-01 12:56:35 -07:00
slowvote Deprecate ancient "slowvote.info" API method 2019-07-31 11:28:08 -07:00
spaces Remove "Editable By" description fields in Passphrase, Phame, and Spaces 2019-09-12 09:36:50 -07:00
subscriptions When sorting subscriber references for display in the curtain UI, sort without case sensitivity 2020-02-04 15:26:05 -08:00
support/application
system Make "View as Document Type..." only show valid options 2020-05-12 14:25:37 -07:00
tokens Allow tokens to be awarded to MFA-required objects 2018-12-28 00:14:48 -08:00
transactions Fix an issue where inline comments with only edit suggestions are considered empty 2020-05-23 08:24:57 -07:00
typeahead Make Portals indexable with Ferret 2019-04-10 13:33:54 -07:00
uiexample Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00